feat: add support for txt files #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caixetadev
added a commit
to Caixetadev/go-fast-cdn
that referenced
this pull request
Jan 28, 2024
kevinanielsen
added a commit
that referenced
this pull request
Jan 30, 2024
* refactor: change folder name * refactor: page structure * fix: adding the right module path * feat: upload multiple files (#116) * feat: add property 'multiple' to file input * feat: sends multiple documents or images to api * fix: show icon for each file being uploaded * fix: refresh page after uploading all files * chore: add semicolons * fix: cards overflow * chore: add EOF * fix: prevent file name overflow in card Co-authored-by: Kevin Nielsen <keveran@gmail.com> * chore: fix indentation --------- Co-authored-by: Kevin Nielsen <keveran@gmail.com> * feat: support for more OS (#117) * feat: add support for txt files (#120) * docs: fix readme link to goreportcard * chore: fix typos across files (#121) * Update handleImageResize.go * fix: successfully typo * refactor: rename folder * refactor: remove folder backend * refactor: move to root * fix: paths * build: run go mod tidy --------- Co-authored-by: Wallys Ferreira <wallysfsilva@gmail.com> Co-authored-by: Kevin Nielsen <keveran@gmail.com> Co-authored-by: Kevin Nielsen <kevinanielsen@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when I tried to send a .txt file, it returned an error saying it wasn't supported, even though the map had the option for txt. The issue arose because my file had charset=utf-8, and since there was no corresponding entry in the map, it resulted in an error. I chose not to remove text/plain because there might be files that aren't in utf-8 format.