feat(ui): Add a resize button to the image content card #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a resize button that opens a modal and let the user change both the width and height of the image
Caixetadev
requested changes
Sep 1, 2024
ui/src/actions/handleResizeImage.ts
Outdated
Comment on lines
22
to
36
| toast.loading("Renaming file..."); | ||
| axios.put(`/api/cdn/resize/image`, JSON.stringify(data)).then((res) => { | ||
| if (res.status === 200) { | ||
| toast.dismiss(); | ||
| toast.success("File resized!"); | ||
|
|
||
| setTimeout(() => { | ||
| location.reload(); | ||
| }, 1500) | ||
| } | ||
| }).catch((err) => { | ||
| toast.dismiss(); | ||
| toast.error("Error: " + err.response.data); | ||
| }) | ||
| } |
There was a problem hiding this comment.
toast.loading returns an id, you can take this id and pass it to success and error so you don't need to use toast.dismiss
Suggested change
| toast.loading("Renaming file..."); | |
| axios.put(`/api/cdn/resize/image`, JSON.stringify(data)).then((res) => { | |
| if (res.status === 200) { | |
| toast.dismiss(); | |
| toast.success("File resized!"); | |
| setTimeout(() => { | |
| location.reload(); | |
| }, 1500) | |
| } | |
| }).catch((err) => { | |
| toast.dismiss(); | |
| toast.error("Error: " + err.response.data); | |
| }) | |
| } | |
| const toastId = toast.loading("Renaming file..."); | |
| axios.put(`/api/cdn/resize/image`, JSON.stringify(data)).then((res) => { | |
| if (res.status === 200) { | |
| toast.success("File resized!", { id: toastId, duration: 4000 }); | |
| setTimeout(() => { | |
| location.reload(); | |
| }, 1500) | |
| } | |
| }).catch((err) => { | |
| toast.error("Error: " + err.response.data, { id: toastId, duration: 4000 }); | |
| }) | |
| } |
|
fixed in commit 04c9f3d |
Caixetadev
approved these changes
Sep 2, 2024
|
@kevinanielsen LGTM, what do you think? Can we merge? |
Yeah, looks good - Nice job on this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a resize button that opens a modal and let the user change both the width and height of the image
This PR references the issue #90