Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add image resize handler #72

Merged
merged 3 commits into from
Dec 27, 2023
Merged

feat: add image resize handler #72

merged 3 commits into from
Dec 27, 2023

Conversation

juroberttyb
Copy link
Contributor

Description

This PR adds an image resize handler that resizes an image given the filename and resolution.

Changes

Added a new endpoint at api/cdn/resize/image to perform in-place image resizing given the filename and resolution.
The request body structure is as described in the issue.

{
  "filename": "string",
  "width": "number",
  "height": "number",
}

Questions

  1. What change does your PR introduce?

    • Bugfix
    • New Feature
    • Enhancement
    • Refactoring
    • Documentation Update
    • Other

  2. Is this PR related to any open issues?

    • Yes (58)
    • No

@kevinanielsen kevinanielsen added docs Improvements or additions to documentation api Improvements or additions to the api go Language: Go labels Dec 27, 2023
@juroberttyb juroberttyb mentioned this pull request Dec 27, 2023
Closed
@kevinanielsen kevinanielsen added enhancement New feature or request and removed docs Improvements or additions to documentation labels Dec 27, 2023
kevinanielsen
kevinanielsen approved these changes Dec 27, 2023
View reviewed changes
Copy link
Owner

@kevinanielsen kevinanielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great! Thanks a lot for your contribution!
Please let me know if you want to contribute again, you have been a big help! :)

@kevinanielsen kevinanielsen merged commit fdec078 into kevinanielsen:main Dec 27, 2023
2 checks passed
@kevinanielsen kevinanielsen linked an issue Dec 27, 2023 that may be closed by this pull request
[Feature] Add handler for resizing images #58
Closed
@juroberttyb
Copy link
Contributor Author

Glad to hear that. Thanks for taking the time to review and merge the PR. Would try to help improve the backend in future PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinanielsen kevinanielsen kevinanielsen approved these changes

Assignees
No one assigned
Labels
api Improvements or additions to the api enhancement New feature or request go Language: Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Add handler for resizing images
2 participants
@juroberttyb @kevinanielsen