-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add endpoint for getting data about a given document #81
feat: add endpoint for getting data about a given document #81
Conversation
Looks great so far! Documentation would be great! I'm going to assign you to the Issue |
I've added the spec; I'll write some tests later today. Doesn't look like the project has any existing tests, am I correct? |
Wrote tests covering every case except for when os.Stat fails for some reason other than the file not existing. Not sure how I'd force that to happen on demand. |
I think this is ready for review, aside from maybe adding another make target and a github actions job to run the tests. I can do that if you'd like. |
That would be amazing - I am struggling a bit with testing, as I am new to Go. Any contributions would be great! I will review you work for this issue now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
No problem on the testing; I'll open another issue for setting up the make target and github actions job and I'll work on that. |
Related to #75
Adds endpoint at
/api/cdn/doc/:filename
that attempts to get relevant information for the requested document.Example:
GET http://localhost:8080/api/cdn/doc/resume.pdf
returns
Confirmed the
download_url
works by pasting it in a web browserI have not yet written any documentation for this endpoint yet. Wanted to get initial feedback first.