Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated function calls #1441

Merged
merged 11 commits into from
Oct 9, 2023
Merged

Replace deprecated function calls #1441

merged 11 commits into from
Oct 9, 2023

Conversation

lucasnetau
Copy link
Collaborator

A few small fixes bunched together

  • Replace deprecated calls to substr and assigning variables by var
  • Helper functions for parseXML have been prefixed by xml to make their usage clear
  • Apply fix to starRating that was applied to other controls to ensure they can be rendered even if not attached to the DOM

@lucasnetau
fix: Return true from SanatizerAPI backend when successfully setting …
c5d24c8 
…HTML
@lucasnetau
refactor: var to const conversion for constant assignments
a7ffe61
@lucasnetau
fix: Replace non-standard and deprecated call to String.substr() with…
813cecf 
… String.slice()
@lucasnetau
refactor: Prefer positive equality test in comparison than negative e…
80d701a 
…quality test
@lucasnetau
refactor: Prefix XML helper functions used only by parseXML with xml
169667e
@lucasnetau
refactor: Use the short Date.now() instead of constructing a new Date…
c69e8c0 
… to grab the current timestamp
@lucasnetau
fix: Remove unused local variable
53649ae
@lucasnetau
fix: Control may not be instered into the DOM at the time of onRender…
33ea8c4 
…, keep a reference to the element in build() and use in onRender()
@lucasnetau
refactor: var -> const
d2209a4
@lucasnetau
fix: Fix JSDoc
d2b8629
@lucasnetau
fix: Mark XML helper functions as private and don't export them from …
74d19a2 
…utils module
@lucasnetau lucasnetau merged commit 4ef1470 into kevinchappell:master Oct 9, 2023
1 check passed
@lucasnetau lucasnetau deleted the small-fixes branch October 9, 2023 22:59
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

🎉 This PR is included in version 3.13.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lucasnetau