Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a helper function to the uninitialised formBuilder instance #1458

Closed
wants to merge 1 commit into from

Conversation

lucasnetau
Copy link
Collaborator

This change would hopefully stop issues being logged around 'formBuilder.actions.function is not a function TypeError' as it would give feedback that the formBuilder instance is still initialising and they need to wait.

@kevinchappell we could put a URL into the message that takes the developer to the docs around async init? What do you think?

@kevinchappell
Copy link
Owner

This change would hopefully stop issues being logged around 'formBuilder.actions.function is not a function TypeError' as it would give feedback that the formBuilder instance is still initialising and they need to wait.

@kevinchappell we could put a URL into the message that takes the developer to the docs around async init? What do you think?

That is a great idea. Should we make that message translatable?

@lucasnetau
Copy link
Collaborator Author

@kevinchappell mi18n may not be initialised by that time, so I'm guessing I need a fallback

@kevinchappell
Copy link
Owner

kevinchappell commented Oct 19, 2023

@kevinchappell mi18n may not be initialised by that time, so I'm guessing I need a fallback

Ah right of course. English should be fine for this type message because i think mostly developers would see it.

I like the URL idea to better explain the problem

@lucasnetau
Copy link
Collaborator Author

Closed in favour of #1459

@lucasnetau lucasnetau closed this Oct 19, 2023
@lucasnetau lucasnetau deleted the not-initialised branch October 31, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants