Refactor initialisation of the formBuilder plugin to ensure two or more concurrent initialisations cannot interfere with each other #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasnetau
force-pushed
the
unique-methods
branch
from
9c7c95e to
699e20e
Compare
lucasnetau
changed the title
lucasnetau
force-pushed
the
unique-methods
branch
from
699e20e to
94894a5
Compare
… two or more concurrent initialisations cannot interfere with each other
lucasnetau
force-pushed
the
unique-methods
branch
from
94894a5 to
199c1cd
Compare
kevinchappell
approved these changes
Oct 19, 2023
|
🎉 This PR is included in version 3.16.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialising two formBuilders concurrently would cause all but the last instance to be incorrectly initialised. Refactor this to using a initialisation function to isolate the plugin instance and store it in a data attribute for later use.
Additionally an uninitialised placeholder function has been put in place when actions are called before the formBuilder is initialised (when not using promise interface)
Both of these changes should reduce issue spam and also improve new developer experience by not having to load multi formBuilders in a recursive function or awaiting in a loop.
Tests have been added to check for concurrent loading, all existing tests pass after this change.
Closes: #1087
Closes: #1000
References: #965
References: #1088
References: #1340
References: #1383