Fix bugs related to textarea.quill #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lucasnetau
commented
Oct 26, 2023
lucasnetau
commented
- quill.textarea contains SVG graphics. This caused getAllGridRelatedClasses to throw a exception due to SVG className property being a SVGAnimatedString instead of a string
- quill.textarea is incompatible with form-control class, strip this in the build stage Fixes quill editor looks wrong #677
- Double clicking on a textarea or on content within a content editable field (eg textarea.quill) would cause the edit box to toggle. Add textarea to the exclusion list and also use the isContentEditable property instead of the contentEditable attribute to detect the editable state
…rea. Additionally, use the property isContentEditable to check if the element double-clicked is a descendant of a contenteditable field (eg a paragraph withing a div[contenteditable])
…perty is a SVGAnimatedString not a string. Controls like textarea.quill have SVG graphics in their element list.
…is class is incompatible with the quill control
|
🎉 This PR is included in version 3.16.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.