Bootstrap feature updates #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lucasnetau
commented
Nov 5, 2023
lucasnetau
commented
- Remove redundant checkSetupBlankStage() check and row creation. Changes in previous PRs made this redundant and the original code had an issue leaving a dangling row in the stage.
- Remove a redundant branch between dropping to a new row or dropping to a placeholder
- Add additional checkRowCleanup() after dropping controls. Mouse drag of controls could sometimes lead to placeholders not been cleanup and placing whitespace through the stage.
- Store the row ID in a data-row-id attribute. This allows CSS rules to display information like row name in a information panel above each row.
- Fallback to showing controlType: name in formBuilder when the label is blank. This improves UX of controls on the stage
…eck as droppingToNewRow, and simplify the logic.
…ack to 'type: name' for the control label to ensure a value is visible on the stage
kevinchappell
approved these changes
Nov 7, 2023
src/js/form-builder.js
Outdated
| $targetInsertWrapper = $(ui.item).parent() | ||
| setupSortableRowWrapper(rowWrapperNode) | ||
| syncFieldWithNewRow(colWrapper.attr('id')) | ||
| checkRowCleanup() |
There was a problem hiding this comment.
do we need this if its called below?
There was a problem hiding this comment.
You are correct. I've removed the redundant checkRowCleanup() here
|
just had the one question but this is good to merge when youre ready |
|
🎉 This PR is included in version 3.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.