Fix regression in v3.19.2, typeUserAttrs of type string failed to restore user set formData #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… load formData
Closed
isnanwicaks
approved these changes
Mar 4, 2024
problem solved, thank you sir |
|
🎉 This PR is included in version 3.19.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inputUserAttrs only tried to load values from attrs[value] and not attrs[attributeName] like other typeUserAttrs helpers, this meant that only the value from the definition was used and not any value set for the attribute in the formData.
All bases covered with typeUserAttrs by setting attrs[value] to attrs[attributeName] during attribute rendering and also inputUserAttrs modified to check for the attribute value.
Test cases added for string, number, boolean (checkbox) and array (select) typeUserAttrs
Fixes: #1530
Fixes: #1533