Skip to content
This repository has been archived by the owner on Dec 14, 2023. It is now read-only.

BootKeyboard doesn't send ErrorKeyRollover when too many keys are pressed #98

Open
tlyu opened this issue Mar 1, 2023 · 2 comments · May be fixed by #100
Open

BootKeyboard doesn't send ErrorKeyRollover when too many keys are pressed #98

tlyu opened this issue Mar 1, 2023 · 2 comments · May be fixed by #100

Comments

@tlyu
Copy link

tlyu commented Mar 1, 2023

According to the HID spec, we should send ErrorKeyRollover in all positions when there are more (non-modifier) keys pressed on the Boot Keyboard than there are positions in the Boot Report. We currently do not.

@gedankenexperimenter
Copy link

Before making this change, we should really find out what all the common operating systems do in response to those reports.

@tlyu tlyu linked a pull request Nov 30, 2023 that will close this issue
@tlyu
Copy link
Author

tlyu commented Dec 3, 2023

Before making this change, we should really find out what all the common operating systems do in response to those reports.

It's standard behavior required by the HID specification for boot protocol, and every other keyboard I've tested so far correctly sends ErrorKeyRollover if too many keys are pressed at once (which can be fewer than 6, on cheaper keyboards without a full diode matrix).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants