chore: remove deprecated field data from keyboard_info usage 🎺 #204
Conversation
mcdurdin
changed the title
1. We still have the old data in the search test fixtures, so restore the fixtures. 2. The legacyid search is no longer relevant, so remove the test.
|
Thought this was ready to go and then I looked at the schema again oops |
Synchronizes recent changes in keymanapp/keyman repo.
| @@ -113,23 +113,6 @@ public function testSearchByKeyboardId() | |||
| $this->assertEquals('keyboard_id', $json->keyboards[0]->match->type); | |||
| } | |||
|
|
|||
| public function testSearchByLegacyKeyboardId() | |||
There was a problem hiding this comment.
Does this get removed in a Search30Test.php?
There was a problem hiding this comment.
Sorry, I don't understand the question?
There was a problem hiding this comment.
Search20Test.php uses /search/2.0/search.json
https://github.com/keymanapp/api.keyman.com/blob/be87e96ec10df73534eb758403e1fdcd88f8d55c/tests/Search20Test.php#L14C37-L14C61
Do we need a Search30Test.php that uses /search/3.0/search.json for tests?
There was a problem hiding this comment.
No, because this is a test of the search 2.0 api, and we haven't got a search 3.0 api.
There was a problem hiding this comment.
We've got a search 3.0 schema but not a search 3.0 api. Confuse much? Basically search 3.0 less data than search 2.0.
Relates to keymanapp/keyman#9351.