Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove old fields from keyboard_info 🎺 #2337

Merged

Conversation

mcdurdin
Copy link
Member

Relates to keymanapp/keyman#9351.

Removes:

  • links --> details moved into description field
  • legacyId --> from old Tavultesoft infrastructure, very much obsolete at this point
  • documentationFilename, documentationFileSize --> essentially unused, never referenced by websites
  • related[].note --> only ever used by one keyboard

Relates to keymanapp/keyman#9351.

Removes:
* links --> details moved into description field
* legacyId --> from old Tavultesoft infrastructure, very much obsolete
  t this point
* documentationFilename, documentationFileSize --> essentially unused,
  never referenced by websites
* related[].note --> only ever used by one keyboard
@mcdurdin mcdurdin added the chore label Aug 11, 2023
@mcdurdin mcdurdin changed the title chore: remove old fields from keyboard_info chore: remove old fields from keyboard_info 🎺 Aug 11, 2023
Copy link
Contributor

@LornaSIL LornaSIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks GREAT to me! I've wondered about this many times.

@LornaSIL LornaSIL merged commit 590c248 into chore/filter-keyboard-info Aug 11, 2023
1 check passed
@LornaSIL LornaSIL deleted the chore/remove-old-fields-keyboard-info branch August 11, 2023 13:17
@mcdurdin
Copy link
Member Author

See keymanapp/keyman#9351 to see more changes coming up with the 17.0 compiler!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore epic-package-metadata infrastructure Relating to keyboard search and deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants