feat: use new build script and kmc #2393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves issues around spaces in paths.
darcywong00
reviewed
Oct 23, 2023
darcywong00
reviewed
Oct 23, 2023
| <DisplayFont>'"$displayFont"'</DisplayFont>' | ||
| function do_clean() { | ||
| rm -f ./source/fv_all.kps | ||
| rm -rf ./build/ |
There was a problem hiding this comment.
Do you want to clean these files too?
rm -f build_targets.txt build_targets_temp.txt build_external_targets.txt build_fv_all.txt build_legacy.txt
There was a problem hiding this comment.
ah nvm - I meant in the top build.sh do_clean
darcywong00
reviewed
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2389.
Replaces the old build script with a cleaner version that utilizes builder.inc.sh, standardizing our build commands.
Uses
kmcto build all source models, in a single command rather than one-by-one as previously. Handles external models more simply.TODO:
.../release/packages/fv_all/../../../resources/builder.inc.sh: line 1079: KEYMAN_ROOT: unbound variable(See 3e1368d)Please note: this will merge into staging-17.0, in preparation for 17.0 release. Changes on the staging-17.0 branch will not be published to keyman.com, until they are merged into master when we go to release (or when we determine the updated build tools are sufficiently stable).
Please ignore the failing build in this PR, which is due to data clean required and is addressed in follow-up PRs in the chain (particularly #2404).
Other PRs in this chain: