Skip to content

Commit

Permalink
fix(ios): remove '--debug' from build declaration
Browse files Browse the repository at this point in the history
The '--debug' flag should not be specified as a parameter in the
builder_describe call.
  • Loading branch information
mcdurdin committed Mar 11, 2024
1 parent 585f3b6 commit c99aeca
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 10 deletions.
3 changes: 1 addition & 2 deletions common/web/gesture-recognizer/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ builder_describe "Runs all tests for the gesture-recognizer module" \
"test+" \
":headless Runs headless user tests" \
":browser Runs browser-based user tests" \
"--ci Uses CI-based test configurations & emits CI-friendly test reports" \
"--debug,-d Activates developer-friendly debug mode for unit tests where applicable"
"--ci Uses CI-based test configurations & emits CI-friendly test reports"

builder_parse "$@"

Expand Down
9 changes: 2 additions & 7 deletions ios/samples/common.inc.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@ function do_build() {
cp -Rf "$KEYMAN_ENGINE_FRAMEWORK_SRC" "$KEYMAN_ENGINE_FRAMEWORK_DST"

CODE_SIGN=
# `builder_is_debug_build` appears to fail here, while referring to the option does not?
# Perhaps it's due to the main build definition being within a function?
if builder_has_option --debug; then
if builder_is_debug_build; then
CODE_SIGN=CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED="NO" CODE_SIGNING_ENTITLEMENTS=""
fi

Expand All @@ -30,15 +28,12 @@ function execute_sample_build() {
"clean" \
"configure" \
"build" \
"--debug Avoids codesigning and adds full sourcemaps for the embedded predictive-text engine" \
"--sim-artifact+ Unused by this build at present"

builder_parse "$@"

local CONFIG=Release
# `builder_is_debug_build` appears to fail here, while referring to the option does not?
# Perhaps it's due to being within a function?
if builder_has_option --debug; then
if builder_is_debug_build; then
CONFIG="Debug"
fi

Expand Down
1 change: 0 additions & 1 deletion oem/firstvoices/ios/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ builder_describe "Builds the $TARGET app for use on iOS devices - iPhone and iPa
"clean" \
"configure" \
"build" \
"--debug Avoids codesigning and adds full sourcemaps for the embedded predictive-text engine" \
"--sim-artifact Also outputs a simulator-friendly test artifact corresponding to the build"

builder_parse "$@"
Expand Down

0 comments on commit c99aeca

Please sign in to comment.