Skip to content

Commit

Permalink
fix(core): serialize tests for core/wasm on mac agents
Browse files Browse the repository at this point in the history
Mitigates: #11794
Cherry-pick-of: #11795
  • Loading branch information
mcdurdin committed Jun 17, 2024
1 parent 0d87bd7 commit f8e8d85
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
9 changes: 8 additions & 1 deletion core/commands.inc.sh
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,14 @@ do_test() {
if [[ $target =~ ^(x86|x64)$ ]]; then
cmd //C build.bat $target $BUILDER_CONFIGURATION test $testparams
else
meson test -C "$MESON_PATH" $testparams
if [[ $target == wasm ]] && [[ $BUILDER_OS == mac ]]; then
# 11794 -- parallel tests failing on some mac build agents; temporary
# mitigation until we diagnose root cause
meson test -j 1 -C "$MESON_PATH" $testparams
else
meson test -C "$MESON_PATH" $testparams
fi

fi
builder_finish_action success test:$target
}
Expand Down
2 changes: 1 addition & 1 deletion docs/build/macos.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ PATH="$HOMEBREW_PREFIX/opt/coreutils/libexec/gnubin:$PATH"
* node.js 18+, emscripten, openjdk 8

```shell
brew install node emscripten openjdk@8
brew install node emscripten
```

Note: if you install emscripten with brew on macOS, only emscripten binaries are
Expand Down

0 comments on commit f8e8d85

Please sign in to comment.