Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(developer): package file format should include Options.WelcomeFile 🎺 #9478

Closed
mcdurdin opened this issue Aug 17, 2023 · 0 comments · Fixed by #9709
Closed

feat(developer): package file format should include Options.WelcomeFile 🎺 #9478

mcdurdin opened this issue Aug 17, 2023 · 0 comments · Fixed by #9709
Milestone

Comments

@mcdurdin
Copy link
Member

Currently we assume the presence of welcome.htm by name in packages. In the future, this should be a formal reference in the Options object of kps/kmp.json. See also #9477 for how this allows for other file formats such as Markdown.

The Keyman apps would look first at the WelcomeFile property of kmp.json, and if that is missing, fallback to the old welcome.htm fixed filename.

Consider also localization, which applies to any of these metadata files.

@mcdurdin mcdurdin added this to the A17S22 milestone Aug 17, 2023
@keymanapp-test-bot keymanapp-test-bot bot changed the title feat(developer): package file format should include Options.WelcomeFile feat(developer): package file format should include Options.WelcomeFile 🎺 Sep 15, 2023
@mcdurdin mcdurdin added the m:l10n i18n or l10n of Keyman UI, all platforms label Sep 16, 2023
@mcdurdin mcdurdin modified the milestones: A17S22, A17S23 Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant