feat(developer): escape bad markers 🙀 #10306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- marker overrun! the 40th marker becomes a parenthesis, breaking regex feat(core): ldml proper regex implementation 🙀🙀 #9121
srl295
requested review from
mcdurdin,
darcywong00 and
jahorton
as code owners
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
github-actions
bot
added
developer/
common/
developer/compilers/
common/web/
feat
labels
srl295
changed the title
srl295
force-pushed
the
feat/developer/9121-reject-bad-regex-epic-ldml
branch
from
dbd06e9
to
1a845d1
Compare
srl295
commented
Dec 29, 2023
|
|
||
| <keys> | ||
| <!-- fourty markers. so that the next one would have its representation as '(' --> | ||
| <key id="1" output="\m{m01}\m{m02}\m{m03}\m{m04}\m{m05}\m{m06}\m{m07}\m{m08}\m{m09}\m{m10}\m{m11}\m{m12}\m{m13}\m{m14}\m{m15}\m{m16}\m{m17}\m{m18}\m{m19}\m{m20}\m{m21}\m{m22}\m{m23}\m{m24}\m{m25}\m{m26}\m{m27}\m{m28}\m{m29}\m{m30}\m{m31}\m{m32}\m{m33}\m{m34}\m{m35}\m{m36}\m{m37}\m{m38}\m{m39}\m{m40}"/> |
|
interesting. So, normalize_nfd_markers(patstr);Doesn't work anymore, because it expects the sentinel pattern, not: U+FFFF U+0008 probably scrambles it. So I need a new kind of 'normalize_nfd_markers' (or a switch) that works w/ regex pattern space. |
- escape markers to prevent the n'th marker from having some other meaning
- needed to remove/re-add the “≈≈[\u0001-\uD7FE]” format (aka LDML_MARKER_ANY_INDEX) #9121
srl295
force-pushed
the
feat/developer/9121-reject-bad-regex-epic-ldml
branch
from
1a845d1
to
02ba64d
Compare
|
the parse/format could be more optimized. or maybe use something from ICU. |
mcdurdin
approved these changes
Jan 2, 2024
Co-authored-by: Marc Durdin <marc@durdin.net>
…per/9121-reject-bad-regex-epic-ldml
- move prepend_marker out of line - replace bool for_regex with an enum - cleanup another instance of \b -> \u0008 #9121
Base automatically changed from
chore/core/ldml-test-robust-epic-ldml
to
master
January 3, 2024 17:47
|
Changes in this pull request will be available for download in Keyman version 17.0.238-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\u0001format) to prevent the n'th marker from having some other meaning!#9121
@keymanapp-test-bot skip