Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(developer): kmc keyboard info compiler messages unit tests #10848

Merged
merged 18 commits into from
Mar 13, 2024
Merged

test(developer): kmc keyboard info compiler messages unit tests #10848

merged 18 commits into from
Mar 13, 2024

Conversation

markcsinclair
Copy link
Contributor

@markcsinclair markcsinclair commented Feb 26, 2024 •
edited by mcdurdin
Loading

Replaces #9926

@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Feb 26, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Feb 26, 2024 •
edited
Loading

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the B17S2 milestone Feb 26, 2024
@markcsinclair
Copy link
Contributor Author

@keymanapp-test-bot skip

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-missing User tests have not yet been defined for the PR label Feb 26, 2024
@markcsinclair markcsinclair marked this pull request as draft February 26, 2024 12:49
@markcsinclair markcsinclair changed the title Test(developer): kmc keyboard info unit tests test(developer): kmc keyboard info unit tests Feb 26, 2024
@markcsinclair markcsinclair self-assigned this Feb 26, 2024
@mcdurdin mcdurdin mentioned this pull request Feb 26, 2024
Closed
@mcdurdin mcdurdin modified the milestones: B17S2, B17S3 Mar 3, 2024
@markcsinclair
chore(developer): add ERROR_FileDoesNotExist (font file not on disk) …
41ec7cf 
…test
@markcsinclair
chore(developer): add ERROR_LicenseFileIsMissing test
98764dc
@markcsinclair
chore(developer): add missing 'ERROR_' to test descriptions for FileD…
4cf4efc 
…oesNotExist
@markcsinclair
chore(developer): add ERROR_LicenseFileIsDamaged (error on decode) test
d790a2d
@markcsinclair
chore(developer): add ERROR_LicenseFileIsDamaged (null on decode) test
f9a2e92
@markcsinclair
chore(developer): add ERROR_LicenseIsNotValid test; ensure TextDecode…
cb6cc46 
…r.decode restored in two tests
@markcsinclair
chore(developer): Merge branch 'beta' into test/developer/kmc-keyboar…
e917664 
…d-info-unit-test
@markcsinclair
chore(developer): correct test description for ERROR_FileDoesNotExist…
37b26ba 
… (.kmp fileSize) test
@markcsinclair
chore(developer): refactor to place keyboard info message unit tests …
be8ab1d 
…in correct test file
@markcsinclair
chore(developer): add ERROR_CannotBuildWithoutKmpFile test
911cae6
@markcsinclair
chore(developer): add ERROR_NoLicenseFound test
fa89f06
@markcsinclair markcsinclair changed the title test(developer): kmc keyboard info unit tests test(developer): kmc keyboard info compiler messages unit tests Mar 12, 2024
@markcsinclair
Copy link
Contributor Author

markcsinclair commented Mar 12, 2024 •
edited
Loading

I have moved the test from the earlier fix (ERROR_FileDoesNotExist (.kmp fileSize)) to test-info-compiler-messages.ts, where I have added all the other message related tests. [I have also been able to remove some more of the fixture files from the test for ERROR_FileDoesNotExist (.kmp fileSize)]

The following errors do not seem to be used, so no tests have been written: Error_FileIsNotValid, Warn_MetadataFieldInconsistent, Hint_OutputValidation, Warn_OutputValidation, Error_OutputValidation; in addition, Error_InvalidAuthorEmail was previously marked as covered; finally, ERROR_FontFileCannotBeRead will be tested as part of a forthcoming fix.

@markcsinclair markcsinclair marked this pull request as ready for review March 12, 2024 18:14
mcdurdin
mcdurdin approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should open an issue to remove the unused messages

@markcsinclair markcsinclair merged commit ae118f4 into beta Mar 13, 2024
4 checks passed
@markcsinclair markcsinclair deleted the test/developer/kmc-keyboard-info-unit-test branch March 13, 2024 08:47
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.288-beta

@markcsinclair markcsinclair mentioned this pull request Apr 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdurdin mcdurdin mcdurdin approved these changes

@darcywong00 darcywong00 Awaiting requested review from darcywong00

Assignees

@markcsinclair markcsinclair

Labels
developer/compilers/ developer/
Projects
None yet
Milestone
B17S3
Development

Successfully merging this pull request may close these issues.
3 participants
@markcsinclair @keyman-server @mcdurdin