Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): sample build script --debug detection #10953

Merged
merged 4 commits into from
Apr 17, 2024
Merged

fix(ios): sample build script --debug detection #10953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
39c0cf6
fix(ios): sample build script --debug detection
Mar 6, 2024
680c726
chore(ios): Merge branch 'beta' into fix/ios/sample-builds
Mar 6, 2024
585f3b6
chore(ios): minor cleanup
Mar 6, 2024
c99aeca
fix(ios): remove '--debug' from build declaration
mcdurdin Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions common/web/gesture-recognizer/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ builder_describe "Runs all tests for the gesture-recognizer module" \
"test+" \
":headless Runs headless user tests" \
":browser Runs browser-based user tests" \
"--ci Uses CI-based test configurations & emits CI-friendly test reports" \
"--debug,-d Activates developer-friendly debug mode for unit tests where applicable"
"--ci Uses CI-based test configurations & emits CI-friendly test reports"

builder_parse "$@"

Expand Down
2 changes: 1 addition & 1 deletion ios/keyman/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ if builder_is_debug_build; then
fi

builder_describe_outputs \
build /ios/build/Build/Products/Release-iphoneos/Keyman.xcarchive
build /ios/build/Build/Products/${CONFIG}-iphoneos/Keyman.xcarchive

# Base definitions (must be before do_clean call)
DERIVED_DATA="$KEYMAN_ROOT/ios/build"
Expand Down
5 changes: 1 addition & 4 deletions ios/samples/common.inc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@ function do_build() {
cp -Rf "$KEYMAN_ENGINE_FRAMEWORK_SRC" "$KEYMAN_ENGINE_FRAMEWORK_DST"

CODE_SIGN=
# `builder_is_debug_build` appears to fail here, while referring to the option does not?
# Perhaps it's due to the main build definition being within a function?
if builder_has_option --debug; then
if builder_is_debug_build; then
CODE_SIGN=CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED="NO" CODE_SIGNING_ENTITLEMENTS=""
fi

Expand All @@ -30,7 +28,6 @@ function execute_sample_build() {
"clean" \
"configure" \
"build" \
"--debug Avoids codesigning and adds full sourcemaps for the embedded predictive-text engine" \
"--sim-artifact+ Unused by this build at present"

builder_parse "$@"
Expand Down
1 change: 0 additions & 1 deletion oem/firstvoices/ios/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ builder_describe "Builds the $TARGET app for use on iOS devices - iPhone and iPa
"clean" \
"configure" \
"build" \
"--debug Avoids codesigning and adds full sourcemaps for the embedded predictive-text engine" \
"--sim-artifact Also outputs a simulator-friendly test artifact corresponding to the build"

builder_parse "$@"
Expand Down
Loading