fix(ios): selection range sync for long contexts #10956

jahorton · 2024-03-06T08:18:25Z

Fixes corrections and predictions after recently-typed paragraph breaks.

So... I forgot to properly remap the selection-range coordinates when updating the internal web-engine's context across paragraph boundaries in #10728. Fortunately, the mapping calculations are pretty simple - we only avoid resetting context if there's a very specific relation between the old and new left-hand contexts, after all.

User Testing

To easily navigate to this page from a mobile device:

Sample text:

Almost half of all people in the world today speak an Indo-European language.

Over the last couple of hundred years, linguists have figured out a lot about the first Indo-European language including many

TEST_NEW_PARAGRAPH_PREDICTIONS: Using the sample text specified above as existing context, verify that predictive text operates as expected.

Using Keyman as a system keyboard on an iOS device, paste the "sample text" above into an iOS app.
- Personal recommendation: Notes app
- If using Simulator to test: Messages app
After pasting, the text insertion point should be at the end of the pasted text. If not, make it so.
Hit ENTER twice.
If no predictions are shown at this specific moment, this is fine - it's a separate issue.
Type p, then hit backspace to delete it.
Verify that the usual default suggestions are displayed: "the", "to", "and", etc.
Type ot and verify that suggestions mostly starting with o and t are displayed.
Select others and verify that the expected results occur.
Once applied, directly apply suggestions that pop up at least ten times. Verify that each is applied as expected.

TEST_PREDICTION_AFTER_DELETIONS: Using the same sample text as specified above, verify that predictive text operates as expected after deleting lots of text.

Using Keyman as a system keyboard on an iOS device, paste the "sample text" above into an iOS app.
- Personal recommendation: Notes
- If using Simulator to test: Messages
After pasting, the text insertion point should be at the end of the pasted text. If not, make it so.
Hit ENTER twice.
Type others.
Press and hold backspace until you reach the middle of the second paragraph - try to stop in the middle of a word.
If not in the middle of a word, tap backspace a few times until the text insertion point is in the middle of a word.
Verify that the suggestions shown are all suggestions that make sense for the half-word.
- Example: if you've deleted part of about and are now at abo, the following make sense as the first suggestions: "about", "above", "abortion". Other suggestions should include at least two of the three letters as well.
Apply one of the displayed suggestions and verify that it acts as expected.

TEST_PREDICTION_AFTER_MOVE:
Using the same sample text as specified above, verify that predictive text operates as expected after deleting lots of text.

Using Keyman as a system keyboard on an iOS device, paste the "sample text" above into an iOS app.
- Personal recommendation: Notes
- If using Simulator to test: Messages
After pasting, the text insertion point should be at the end of the pasted text. If not, make it so.
Move the text insertion point into the middle of the word peo ple, which is in the middle of the first paragraph.
Verify that the suggestions shown are all suggestions that make sense for peo: you might expect to see "people", "people's", "peoples", "person", etc.
Apply one of the displayed suggestions and verify that it acts as expected.

keymanapp-test-bot · 2024-03-06T08:18:29Z

User Test Results

Test specification and instructions

✅ TEST_NEW_PARAGRAPH_PREDICTIONS (PASSED): Tested with the attached PR build on iPhone 13 Mobile (iOS 17.4) device and here is my observation: 1. Copied the given text then pasted it in Notes app. 2. Hit Enter key twice. 3. Typed p, then hit the backspace key to delete it. 4. Verified that the usual default suggestions are displayed. 5. Typed 'ot' and verified that the suggestions mostly started with o and t are displayed. 6. Selected 'others' from the suggestion bar and verified that it displayed on the text input screen. 7. Directly applied suggestions from that pop up at least ten time. Verified that the applied suggestions are displayed on the input screen. (notes)
✅ TEST_PREDICTION_AFTER_DELETIONS (PASSED): Tested with the attached PR build on iPhone 13 Mobile (iOS 17.4) device and here is my observation: 1. Copied the given text then pasted it in Notes app. 2. Hit Enter key twice. 3. Typed 'others'. 4. Pressed and held down the backspace key a few times until the text insertion point is in the middle of the word. 5. Verified that the suggestions shown are all suggestions that make sense for the half-word. 6. Applied one of the displayed suggestions and verified that it showed the expected result on the screen. (notes)
✅ TEST_PREDICTION_AFTER_MOVE (PASSED): Tested with the attached PR build (17.0.283-beta-test-10956) on an iPhone 13 Mobile (iOS 17.4) device and here is my observation: 1. Copied the given text then pasted it in Notes app. 2. Moved the txt insertion point into the middle of the word (eg., in between peo and ple)which is in the middle of the first paragraph. 3. Verified that the suggestions shown are all suggestions that are related to 'peo'. 4. I selected 'person' from the banner and verified that it replaced 'people' on the text input screen with 'Person'. (notes)

Test Artifacts

Android
Developer
iOS
- Keyman for iOS (simulator image)
- FirstVoices Keyboards for iOS (simulator image)
- TestFlight internal PR build version - 17.0.283 (0.10956.10588)
Keyboards
- Test Keyboards
Web
- KeymanWeb Test Home
Windows

bharanidharanj · 2024-03-08T11:19:44Z

Test Results

TEST_NEW_PARAGRAPH_PREDICTIONS (PASSED): Tested with the attached PR build on iPhone 13 Mobile (iOS 17.4) device and here is my observation: 1. Copied the given text then pasted it in Notes app. 2. Hit Enter key twice. 3. Typed p, then hit the backspace key to delete it. 4. Verified that the usual default suggestions are displayed. 5. Typed 'ot' and verified that the suggestions mostly started with o and t are displayed. 6. Selected 'others' from the suggestion bar and verified that it displayed on the text input screen. 7. Directly applied suggestions from that pop up at least ten time. Verified that the applied suggestions are displayed on the input screen.

bharanidharanj · 2024-03-08T12:11:14Z

Test Results

TEST_PREDICTION_AFTER_DELETIONS (PASSED): Tested with the attached PR build on iPhone 13 Mobile (iOS 17.4) device and here is my observation: 1. Copied the given text then pasted it in Notes app. 2. Hit Enter key twice. 3. Typed 'others'. 4. Pressed and held down the backspace key a few times until the text insertion point is in the middle of the word. 5. Verified that the suggestions shown are all suggestions that make sense for the half-word. 6. Applied one of the displayed suggestions and verified that it showed the expected result on the screen.

bharanidharanj · 2024-03-08T12:33:17Z

Test Results

TEST_PREDICTION_AFTER_MOVE (FAILED): Tested with the attached PR build on iPhone 13 Mobile (iOS 17.4) device and here is my observation: 1. Copied the given text then pasted it in Notes app. 2. Moved the txt insertion point into the middle of the word (eg., in between peo and ple)which is in the middle of the first paragraph. 3. Noticed that the unpredicted words appeared on the suggestion bar. Seems to be an issue.

mcdurdin

I think LGTM

jahorton · 2024-03-12T16:41:13Z

@keymanapp-test-bot retest TEST_PREDICTION_AFTER_MOVE

Glad I spec'd that user test. I believe I've identified and fixed the issues causing the problem now; "hard context resets" were also using the codepaths meant for non-reset cases by mistake.

jahorton · 2024-03-15T13:37:26Z

The build has failed a few times now with this error set during the "Upload to TestFlight" step:

19:44:34 
  DEBUG [2024-03-15 23:44:33.98]: [altool]: 2024-03-15 23:44:33.983 DEBUG: Adding upload task 90131 for part 1.

19:44:34 
  

19:44:34 
  DEBUG [2024-03-15 23:44:33.98]: [altool]:     "LocalUploadTask <F57B37EC-277D-4824-B286-C3393A2D27DE>.<90130>"

19:44:34 
  

19:44:34 
  DEBUG [2024-03-15 23:44:33.98]: [altool]: ), NSLocalizedDescription=A server with the specified hostname could not be found., NSErrorFailingURLStringKey=https://northamerica-1.object-storage.apple.com/itmspod11-assets-massilia-200001/PurpleSource211%2Fv4%2Fcd%2F7a%2F94%2Fcd7a94f9-e61d-72b8-7d63-a7d98b7e09d0%2FzdNd26rtHz3H6IPNT3PgTTlx-mNkSbv9_5UvwiUtan8_U003d-1710506561722?uploadId=837bda20-e2c9-11ee-a5ef-783fd2d59ff3&Signature=SvvrmRTL%2BQnksXg31t5hLfwQxMo%3D&AWSAccessKeyId=MKIAP7F9QNTEY48OTE7F&partNumber=1&Expires=1711111361, NSErrorFailingURLKey=https://northamerica-1.object-storage.apple.com/itmspod11-assets-massilia-200001/PurpleSource211%2Fv4%2Fcd%2F7a%2F94%2Fcd7a94f9-e61d-72b8-7d63-a7d98b7e09d0%2FzdNd26rtHz3H6IPNT3PgTTlx-mNkSbv9_5UvwiUtan8_U003d-1710506561722?uploadId=837bda20-e2c9-11ee-a5ef-783fd2d59ff3&Signature=SvvrmRTL%2BQnksXg31t5hLfwQxMo%3D&AWSAccessKeyId=MKIAP7F9QNTEY48OTE7F&partNumber=1&Expires=1711111361, _kCFStreamErrorDomainKey=12}

19:44:34 
  

19:44:34 
  DEBUG [2024-03-15 23:44:33.98]: [altool]: 2024-03-15 23:44:33.984 DEBUG: Created new upload task (0x1537303b0) for part 1.

19:44:34 
  

19:44:34 
  DEBUG [2024-03-15 23:44:33.98]: [altool]: 2024-03-15 23:44:33.984 DEBUG: Saving uploader state (CDUploaderStateUploadAssetDescription) for identifier 'com.apple.cds_4BCE69C2-E5DF-42FA-9C0E-B783323F9738'.

19:44:34 
  

19:44:34 
  DEBUG [2024-03-15 23:44:33.98]: [altool]: 2024-03-15 23:44:33.985 DEBUG: There is one part remaining to upload.

19:44:34 
  

19:44:34 
  DEBUG [2024-03-15 23:44:33.98]: [altool]: 2024-03-15 23:44:33.987 DEBUG: LOST 0 bytes for part 1.

This is constantly repeated in the TC build logs.

mcdurdin · 2024-03-15T15:54:06Z

Hmm, altool was deprecated wasn't it? Or was it only specific tasks for altool. Can you break that into a separate issue?

mcdurdin · 2024-03-16T02:25:05Z

I've upgraded fastlane and retried another build, which worked, so retrying this ios build now.

bharanidharanj · 2024-03-18T13:27:55Z

Test Results

TEST_PREDICTION_AFTER_MOVE (PASSED): Tested with the attached PR build (17.0.283-beta-test-10956) on an iPhone 13 Mobile (iOS 17.4) device and here is my observation: 1. Copied the given text then pasted it in Notes app. 2. Moved the txt insertion point into the middle of the word (eg., in between peo and ple)which is in the middle of the first paragraph. 3. Verified that the suggestions shown are all suggestions that are related to 'peo'. 4. I selected 'person' from the banner and verified that it replaced 'people' on the text input screen with 'Person'.

..before selection

..after selection

keyman-server · 2024-03-19T18:03:34Z

Changes in this pull request will be available for download in Keyman version 17.0.290-beta

fix(ios): selection range sync for long contexts

4b11a5d

keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Mar 6, 2024

keymanapp-test-bot bot added this to the B17S3 milestone Mar 6, 2024

github-actions bot added web/ fix ios/ labels Mar 6, 2024

keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed and removed user-test-missing User tests have not yet been defined for the PR labels Mar 8, 2024

jahorton marked this pull request as ready for review March 8, 2024 02:39

jahorton requested a review from ermshiperete as a code owner March 8, 2024 02:39

keymanapp-test-bot bot added user-test-failed and removed user-test-required User tests have not been completed labels Mar 8, 2024

mcdurdin approved these changes Mar 11, 2024

View reviewed changes

fix(ios): hard context resets

3240ee7

jahorton requested a review from sgschantz as a code owner March 12, 2024 16:38

github-actions bot added the ios/engine/ label Mar 12, 2024

keymanapp-test-bot bot added user-test-required User tests have not been completed and removed user-test-failed labels Mar 12, 2024

jahorton mentioned this pull request Mar 13, 2024

fix(web): proper linkage of sources to events 🪠 #10960

Merged

darcywong00 modified the milestones: B17S3, B17S4 Mar 16, 2024

keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Mar 18, 2024

jahorton merged commit 8e4a80f into beta Mar 19, 2024
15 checks passed

jahorton deleted the fix/ios/sliding-context-range branch March 19, 2024 03:15

jahorton mentioned this pull request Jun 17, 2024

bug(ios): The predictive text did not reappear in the suggestion bar after clearing the symbols (<>/) using Clear text option #10979

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ios): selection range sync for long contexts #10956

fix(ios): selection range sync for long contexts #10956

jahorton commented Mar 6, 2024 •

edited

Loading

keymanapp-test-bot bot commented Mar 6, 2024 •

edited

Loading

bharanidharanj commented Mar 8, 2024

bharanidharanj commented Mar 8, 2024

bharanidharanj commented Mar 8, 2024

mcdurdin left a comment

jahorton commented Mar 12, 2024

jahorton commented Mar 15, 2024 •

edited

Loading

mcdurdin commented Mar 15, 2024

mcdurdin commented Mar 16, 2024

bharanidharanj commented Mar 18, 2024

keyman-server commented Mar 19, 2024

fix(ios): selection range sync for long contexts #10956

fix(ios): selection range sync for long contexts #10956

Conversation

jahorton commented Mar 6, 2024 • edited Loading

User Testing

keymanapp-test-bot bot commented Mar 6, 2024 • edited Loading

User Test Results

Test Artifacts

bharanidharanj commented Mar 8, 2024

Test Results

bharanidharanj commented Mar 8, 2024

Test Results

bharanidharanj commented Mar 8, 2024

Test Results

mcdurdin left a comment

Choose a reason for hiding this comment

jahorton commented Mar 12, 2024

jahorton commented Mar 15, 2024 • edited Loading

mcdurdin commented Mar 15, 2024

mcdurdin commented Mar 16, 2024

bharanidharanj commented Mar 18, 2024

Test Results

keyman-server commented Mar 19, 2024

jahorton commented Mar 6, 2024 •

edited

Loading

keymanapp-test-bot bot commented Mar 6, 2024 •

edited

Loading

jahorton commented Mar 15, 2024 •

edited

Loading