Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(developer): keyboard info compiler unit tests #11000

Merged
merged 37 commits into from
Apr 2, 2024

Conversation

markcsinclair
Copy link
Contributor

Tests for the keyboard info compiler

@keymanapp-test-bot skip

@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Mar 14, 2024

User Test Results

Test specification and instructions

User tests are not required

@keymanapp-test-bot keymanapp-test-bot bot added this to the B17S3 milestone Mar 14, 2024
@markcsinclair markcsinclair marked this pull request as draft March 14, 2024 13:38
@darcywong00 darcywong00 modified the milestones: B17S3, B17S4 Mar 16, 2024
@mcdurdin mcdurdin modified the milestones: B17S4, B17S5 Mar 30, 2024
@markcsinclair markcsinclair marked this pull request as ready for review April 1, 2024 14:12
@markcsinclair
Copy link
Contributor Author

Coverage is improving over keyboard-info-compiler.ts, but more tests are needed for fillLanguages(), fontSourceToKeyboardInfoFont() and the latter part of run().

Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits only, LGTM

@markcsinclair markcsinclair merged commit 9def2da into beta Apr 2, 2024
3 checks passed
@markcsinclair markcsinclair deleted the test/developer/keyboard-info-compiler-unit-tests branch April 2, 2024 13:09
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.300-beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants