chore: Merge beta to master for Sprint B17S3 #11008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IBus around version 1.5.28 introduced the `start` subcommand for `ibus`. If available we use that because that starts `ibus-daemon` with the correct arguments. If the available IBus version is too old we use our previous code where we pass arguments to `ibus-daemon` which might be different from how ibus gets started on that system otherwise.
On Ubuntu 20.04 Focal ibus gets started by a shell command so that we end up with two processes mentioning `ibus-daemon`. This change limits the search to processes that specify with full path to `ibus-daemon` or without path, but `ibus-daemon` has to be the command, not a parameter.
In Keyman 17 Alpha and the first versions of Beta the package name was `libkeymancore` before we changed it to `libkeymancore1`. If that version is installed we can't install the new package because it causes conflicts. This change fixes it.
…previously checked
Fixes #10872. Modifies #10845. developer-utils is also used by server. Because osk.ts depends on common-types, this introduced a transitive dependency for developer-utils. Packaging server for deployment as part of Keyman Developer is fragile and we need to hand-code our internal dependencies, as npm bundling struggles with in-repo dependencies. So we need to avoid introducing extra dependencies into developer-utils at this time. It turns out that osk.ts is used by kmc-kmn and kmc-analyze. kmc-analyze already has a dependency on kmc-kmn, so it makes sense to put it there.
Fixes #10889. This involved a bit more refactoring to help-keyman-com.sh in order to allow for multiple paths to be uploaded. I opted _not_ to move the entire Keyman Developer documentation into this repository, partly because a number of pages are still in PHP rather than Markdown.
api-extractor returned the following error:
```
ERROR: The "export * as ___" syntax is not supported yet; as a workaround, use "import * as ___" with a separate "export { ___ }" declaration
```
Relates to #10207. Note: reduces the API surface by removing members which should be internal. Fixes a few minor typos in other API docs. Adds missing docs for kmc-kmn also.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
github-actions
bot
added
web/
windows/
android/
developer/
ios/
linux/
common/
developer/compilers/
common/resources/
mcdurdin
approved these changes
Mar 16, 2024
|
Changes in this pull request will be available for download in Keyman version 18.0.10-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End of sprint task
I checked TIER.md and VERSION.md unchanged.
@keymanapp-test-bot skip