fix(developer): suppress emission of new empty fields in package editor #11009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #11002. The fields `<RelatedPackages/>` and `<Examples/>` should not be emitted if they have no content, to improve file backward-compatibility.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts |
|
FYI @LornaSIL this should address the back-compat issues you were experiencing with Developer 17, if you don't add details into any of the new fields. |
|
Thank you! I shall reinstall 17 next week!
…On Fri, Mar 15, 2024, 6:44 PM Marc Durdin ***@***.***> wrote:
FYI @LornaSIL <https://github.com/LornaSIL> this should address the
back-compat issues you were experiencing with Developer 17, if you don't
add details into any of the new fields.
—
Reply to this email directly, view it on GitHub
<#11009 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABV6RI37JFKSD7F6KSQOCJ3YYOBW7AVCNFSM6AAAAABEYZU7DKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBQGY3DSOJXGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
mcdurdin
deleted the
fix/developer/11002-kps-editor-should-not-emit-empty-fields
branch
|
@LornaSIL watch this space for a build notification tomorrow |
|
Changes in this pull request will be available for download in Keyman version 17.0.293-beta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11002.
The fields
<RelatedPackages/>and<Examples/>should not be emitted if they have no content, to improve file backward-compatibility.@keymanapp-test-bot skip