-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
epic: user dictionaries 📖 #12124
Draft
mcdurdin
wants to merge
47
commits into
master
Choose a base branch
from
epic/user-dict
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
epic: user dictionaries 📖 #12124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on/models/templates We'll likely want to dynamically build a Trie to represent user-specific entries made available by the active OS. We'll then blend _that_ with the 'static' distributed model.
… improved encapsulation
…ruction' into refactor/common/models/trie-construction-cntd
…ruction-cntd' into change/common/models/trie-construction-cleanup
…xiconTraversals The new `TraversalModel` type inherits almost all code from `TrieModel`, serving as its base class. That said, `TrieModel` will still be responsible for `Trie` loading.
…g multiple models into one
Co-authored-by: Marc Durdin <marc@durdin.net>
…to refactor/common/models/trie-construction
keymanapp-test-bot
bot
added
the
user-test-missing
User tests have not yet been defined for the PR
label
Aug 8, 2024
User Test ResultsTest specification and instructions ERROR: user tests have not yet been defined Test Artifacts
|
…mon/models/trie-model
…ommon/models/trie-model' into refactor/common/models/trie-model
…construction refactor(common/models): move core trie-compilation code into common/models/templates 📖
…construction-cntd refactor(common/models): refactor migrated trie-construction code for improved encapsulation 📖
…nstruction-cleanup change(common/models): add unit tests + optimize live Trie sorting 📖
…rsal-model refactor(common/models): spin off model template based directly on LexiconTraversals 📖
…rsal-children-as-array refactor(common/models): convert traversal.children method to return array 📖
…-dict chore: merge master into user-dict 📖
…models/traversal-compositing
…-compositing feat(common/models): add support for model combining - the CompositedTraversal 📖
…-dict chore: merge master into user-dict
…-dict chore: merge master into user-dict 📖
…-dict chore: merge master into user-dict 📖
…-dict chore: merge master into user-dict 📖
…-dict chore: merge master into user-dict 📖
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
common/models/templates/
common/models/types/
common/models/
common/web/
common/
developer/compilers/
developer/
epic-user-dict
user-test-missing
User tests have not yet been defined for the PR
web/
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.