Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epic: user dictionaries 📖 #12124

Draft
wants to merge 47 commits into
base: master
Choose a base branch
from
Draft

epic: user dictionaries 📖 #12124

wants to merge 47 commits into from

Conversation

mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Aug 8, 2024

No description provided.

jahorton and others added 19 commits August 2, 2024 10:55
…on/models/templates

We'll likely want to dynamically build a Trie to represent user-specific entries made available by the active OS.  We'll then blend _that_ with the 'static' distributed model.
…ruction' into refactor/common/models/trie-construction-cntd
…ruction-cntd' into change/common/models/trie-construction-cleanup
…xiconTraversals

The new `TraversalModel` type inherits almost all code from `TrieModel`, serving as its base class.  That said, `TrieModel` will still be responsible for `Trie` loading.
Co-authored-by: Marc Durdin <marc@durdin.net>
@mcdurdin mcdurdin requested a review from jahorton as a code owner August 8, 2024 00:24
@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Aug 8, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Aug 8, 2024

User Test Results

Test specification and instructions

ERROR: user tests have not yet been defined

Test Artifacts

@mcdurdin mcdurdin marked this pull request as draft August 8, 2024 06:51
…construction

refactor(common/models): move core trie-compilation code into common/models/templates 📖
…construction-cntd

refactor(common/models): refactor migrated trie-construction code for improved encapsulation 📖
…nstruction-cleanup

change(common/models):  add unit tests + optimize live Trie sorting 📖
…rsal-model

refactor(common/models): spin off model template based directly on LexiconTraversals 📖
…rsal-children-as-array

refactor(common/models): convert traversal.children method to return array 📖
@github-actions github-actions bot added the web/ label Aug 22, 2024
@mcdurdin mcdurdin modified the milestones: A18S9, A18S19 Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants