feat: add builder tab-completion script #12296
Open
+122
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
jahorton
commented
Aug 27, 2024
| local _builder_opts=() | ||
| for e in "${!_builder_params[@]}"; do | ||
| if [[ $e =~ ^-- ]]; then | ||
| _builder_opts+=(${e%+*}) |
There was a problem hiding this comment.
Removes all + suffixes from options.
There was a problem hiding this comment.
Removes all
+suffixes from options.
This should be a code comment
jahorton
changed the title
jahorton
force-pushed
the
feat/builder-autocomplete
branch
from
98c475e
to
e6fb213
Compare
github-actions
bot
added
common/models/
common/models/wordbreakers/
and removed
common/models/
common/models/wordbreakers/
labels
|
Accidentally put a commit on the wrong branch for a moment; undid that via a |
|
Hmm... looks like macOS's This may provide a useful first step: https://stackoverflow.com/a/8492043 |
|
I would like to review this before it is merged. However this week I am at capacity. I am happy to take on making any updates and merge, as @jahorton will be away. |
github-actions
bot
added
common/models/
common/models/wordbreakers/
and removed
common/models/
common/models/wordbreakers/
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new resource script -
${KEYMAN_ROOT}/resources/builder_completion.sh. When sourced by a terminal's.bashrcor similar, this script performs tab-completion for any of our builder-based scripts (namedbuild.shortest.sh), expanding for any supported matching actions, targets, and options.Example use case - autocompleting a paired action:target command
To do this, it also adds a hidden option to builder scripts currently called
--builder_completion_describe, which enumerates all actions, then targets, then options in a format easily parsed by the completion script.Autocompletion from empty-string
@keymanapp-test-bot skip