chore(common): Allow to build offline #12439
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
ermshiperete
force-pushed
the
chore/common/offline
branch
from
de980f4
to
c12f788
Compare
A lot of the `configure` actions rely on node dependencies and so call `npm install`. Without a internet connection this hangs forever, even if you had successfully installed the dependencies before and nothing changed since then. This change adds a `--offline` parameter that passes `--prefer-offline` to npm, which causes npm to use the cached dependencies. Also sets the `MESON_PACKAGE_CACHE_DIR` environment variable so that all (sub-)projects share the same package cache dir. This will speed up regular builds a bit (e.g. `developer/src/kmcmplib` and `core` both have `icu4c` as a dependency), but will also help with offline builds. `MESON_PACKAGE_CACHE_DIR` requires Meson 1.3, however older Meson versions ignore this environment variable and simply continue to use a cache per subproject, so will continue to work (minus offline builds).
ermshiperete
force-pushed
the
chore/common/offline
branch
from
c12f788
to
389fb4f
Compare
| builder_echo "Trying offline build" | ||
| offline_param=--prefer-offline | ||
| fi | ||
| try_multiple_times npm ${offline_param} ci |
There was a problem hiding this comment.
We could consider to always pass --prefer-offline which would probably help if nodejs.org has an outage, but I don't know if that has unwanted side-effects.
There was a problem hiding this comment.
I don't know if that's a good idea for build agents?
|
|
||
| # Set shared Meson package cache (works with Meson >= 1.3) | ||
| if [[ -z ${MESON_PACKAGE_CACHE_DIR:-} ]]; then | ||
| export MESON_PACKAGE_CACHE_DIR="${XDG_CACHE_HOME:-${HOME}/.cache}/keyman/builder" |
There was a problem hiding this comment.
Is ~/.cache a safe path? We have already a ~/.keyman path used for nvm (see
Line 33 in aa50672
There was a problem hiding this comment.
~/.cache is the default location for caches on Linux. In contrast to the path for nvm (where the directory contains links to the actual executable). MESON_PACKAGE_CACHE_DIR serves as a real cache that caches the files we have to download. If the files don't exist they'll get downloaded (again). In either case they get extracted/copied to the subprojects folder in e.g. core/src. This means it's safe to delete the files from ~/.cache/keyman/builder, whereas I think the build will fail if ~/.keyman/node doesn't exist. So I'd prefer to put the files under ~/.cache/....
|
Changes in this pull request will be available for download in Keyman version 18.0.116-alpha |
A lot of the
configureactions rely on node dependencies and so callnpm install. Without a internet connection this hangs forever, even if you had successfully installed the dependencies before and nothing changed since then. This change adds a--offlineparameter that passes--prefer-offlineto npm, which causes npm to use the cached dependencies.Also sets the
MESON_PACKAGE_CACHE_DIRenvironment variable so that all (sub-)projects share the same package cache dir. This will speed up regular builds a bit (e.g.developer/src/kmcmplibandcoreboth haveicu4cas a dependency), but will also help with offline builds.MESON_PACKAGE_CACHE_DIRrequires Meson 1.3, however older Meson versions ignore this environment variable and simply continue to use a cache per subproject, so will continue to work (minus offline builds).@keymanapp-test-bot skip