Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): Hide suggestion banner on password fields #12442

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

darcywong00
Copy link
Contributor

Fixes #12441 and needs to 🍒 pick to stable-17.0

This adds a check in System Keyboard to disable suggestion banner on certain fields (e.g. password field)

User Testing

  • Setup - Install the PR build of Keyman for Android on an Android device/emulator

  • TEST_BANNER_DISABLED_ON_PASSWORD - Verifies suggestion banner is disabled on certain fields

  1. Launch Keyman for Android
  2. On the Get Started menu, set Keyman as the default system keyboard
  3. Launch Chrome and select a text area
  4. With Keyman selected as the system keyboard, verify the OSK displays suggestions as you type
  5. On Chrome, go to a page with password fields (e.g. https://darcywong00.github.io/examples/form.html). That page is small so you may need to zoom in
  6. On the test page, select the "Visible Text Field"
  7. Verify the OSK displays suggestions as you type
  8. On the test page, select the "Password Field"
  9. Verify the OSK disables suggestions (replaced with the Keyman banner) as you type
  10. On the test page, select "Search Field"
  11. Verify the OSK re-enables suggestions as you type

@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Sep 19, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Sep 19, 2024

User Test Results

Test specification and instructions

  • TEST_BANNER_DISABLED_ON_PASSWORD (PASSED) (notes)

@dinakaranr
Copy link

Test Results

I tested this issue with the attached "Keyman 18.0.115-alpha-test-12442" build on the Android 14 and Android 12 mobile. Here is my observation.

  • TEST_BANNER_DISABLED_ON_PASSWORD (Passed): 
  1. Installed the "Keyman-18.0.115.apk" file from the PR build. and gave all permissions to the application.
  2. Checked the "Enable Keyman as system-wide keyboard" on the settings page. Checked the "Set Keyman as default keyboard".
  3. Open the Keyman app. Enter some text in the keyman's notepad.
  4. Launch the Chrome browser. Navigate the "editpad.org" website and enter some text on the page.
  5. Verified the suggestion banner appeared and It is showing suggestion on the Keyman banner.
  6. Open a new tab and go to the https://darcywong00.github.io/examples/form.html page.
  7. Verified the test page appeared.
  8. select the "Visible Text Field"
  9. Verified the OSK displays suggestions when typing text.
  10. select the "Password Field"
  11. Verified the OSK disabled suggestions and it is showing the "Keyman banner" OSK
  12. select the "Search Field"
  13. Verified the OSK re-enabled suggestions when typing text.
    It works great for me as per the above steps. Thank you.

I have seen the suggestion appear on the OSK if check the "show password" or "hide the eye icon".

  1. Launch the Chrome browser. Navigate the Login page(e.g. Gmail login or Facebook login)
  2. Click the password box 
  3. Verified the OSK disabled suggestions and it is showing the "Keyman banner" on OSK
  4. Checked the "Show Password" box. (or hide eye icon)
  5. Click the password box.
  6. Verified the OSK enabled the suggestions when typing text.
    Please refer to the video file below
    https://github.com/user-attachments/assets/699ad8bb-4c11-4a3e-a2c5-b177cd3d9479
    https://github.com/user-attachments/assets/5f9c36f2-b827-4dd9-a008-babf323cca61

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Sep 19, 2024
@darcywong00
Copy link
Contributor Author

I have seen the suggestion appear on the OSK if check the "show password" or "hide the eye icon".

Right - I believe those controls alter the text area so it's no longer a password field.

@darcywong00 darcywong00 merged commit becba77 into master Sep 25, 2024
6 checks passed
@darcywong00 darcywong00 deleted the fix/android/disable-banner-password branch September 25, 2024 02:40
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.117-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

bug(android): Suggestion banner doesn't hide on password fields
4 participants