-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): Hide suggestion banner on password fields #12442
Conversation
User Test Results |
Test ResultsI tested this issue with the attached "Keyman 18.0.115-alpha-test-12442" build on the Android 14 and Android 12 mobile. Here is my observation.
I have seen the suggestion appear on the OSK if check the "show password" or "hide the eye icon".
|
Right - I believe those controls alter the text area so it's no longer a password field. |
Changes in this pull request will be available for download in Keyman version 18.0.117-alpha |
Fixes #12441 and needs to 🍒 pick to stable-17.0
This adds a check in System Keyboard to disable suggestion banner on certain fields (e.g. password field)
User Testing
Setup - Install the PR build of Keyman for Android on an Android device/emulator
TEST_BANNER_DISABLED_ON_PASSWORD - Verifies suggestion banner is disabled on certain fields