feat(mac): both option keys generate right alt if no left alt mapping

[sgschantz]

When a keyman keyboard does not define any rules for the Left Alt key, then both the left and right option keys on the Mac keyboard should result in a Right Alt key combination being generated.

Fixes: #875
Fixes: #933

User Testing

• TEST_RALT_KEYBOARD_WITH_BOTH_OPTION_KEYS: Khmer Angkor uses only RALT rules

1. Install this version of Keyman and switch to the Khmer Angkor keyboard
2. Press left-option-Z
3. Confirm that this generates the character '<'
4. Press right-option-Z
5. Confirm that this generates the character '<'

• TEST_RALT_KEYBOARD_WITH_OPTION_KEY_COMBOS: Armenian Mnemonic uses RALT with SHIFT

1. Install and switch to the Armenian Mnemonic keyboard
2. Press left-option-9
3. Confirm that this generates the subscript character '₉'
4. Press shift-left-option-9
5. Confirm that this generates the superscript character '⁹'
6. Press shift-right-option-9
7. Confirm that this generates the same superscript character '⁹'

• TEST_LALT_KEYBOARD_WITH_BOTH_OPTION_KEYS: Devanagari Typewriter uses only LALT rules

1. Install and switch to the Devanagari Typewriter (SIL) keyboard
2. Press control-left-option-COMMA
3. Confirm that this generates the DEVANAGARI DOUBLE DANDA character '॥'
4. Press control-right-option-COMMA
5. Confirm that this generates the comma character ','

[keymanapp-test-bot]

User Test Results

Test specification and instructions

• ✅ TEST_RALT_KEYBOARD_WITH_BOTH_OPTION_KEYS (PASSED) (notes)
• ✅ TEST_RALT_KEYBOARD_WITH_OPTION_KEY_COMBOS (PASSED) (notes)
• ✅ TEST_LALT_KEYBOARD_WITH_BOTH_OPTION_KEYS (PASSED) (notes)

Test Artifacts

• macOS
  • Keyman for macOS

[mcdurdin]

This LGTM, aside from concerns on memory management. Good work

[mcdurdin]

Is keyArray and its members leaked here?

[mcdurdin]

Is keyList leaked here?

[dinakaranr]

Test Results

I tested this issue with the attached "Keyman 18.0.118-alpha-local" build on the macOS Sonoma 14.5 version. here, I am sharing my observation.

• TEST_RALT_KEYBOARD_WITH_BOTH_OPTION_KEYS (passed):

1. Installed the "Keyman 18.0.118-alpha-local" build.
2. Installed the Khmer Angkor keyboard
3. Select the Khmer Angkor keyboard
4. Press left-option-Z
5. Verified that this generates the character '<'
6. Press right-option-Z
7. Verified that this generates the character '<'

• TEST_RALT_KEYBOARD_WITH_OPTION_KEY_COMBOS (passed):

1. Installed the "Keyman 18.0.118-alpha-local" build.
2. Installed the "Armenian Mnemonic" keyboard
3. Select the Armenian Mnemonic keyboard
4. Press left-option-9
5. Verified that this generates the subscript character '₉'
6. Press shift-left-option-9
7. Verified that this generates the superscript character '⁹'
8. Press shift-right-option-9
9. Verified that this generates the same superscript character '⁹'

• TEST_LALT_KEYBOARD_WITH_BOTH_OPTION_KEYS (passed):

1. Installed the "Keyman 18.0.118-alpha-local" build.
2. Installed the "Devanagari Typewrite" keyboard
3. Select the Devanagari Typewriter (SIL) keyboard
4. Press control-left-option-COMMA
5. Verified that this generates the DEVANAGARI DOUBLE DANDA character '॥'
6. Press control-right-option-COMMA
7. Verified that this generates the comma character ','

It works well. Thank you.