Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): implement loading KMX from blob 🎼 #12459

Merged
merged 8 commits into from
Oct 10, 2024

Commits on Sep 24, 2024

  1. feat(core): implement loading KMX from blob

    - split keyboard loading into loading KMX file into blob and then
      loading the keyboard processor from the blob.
    - deprecate `km_core_keyboard_load`
    - move file access next to deprecated method. This is now the only place
      that loads a file in Core; unit tests have some more places that
      load files.
    - introduce GTest and add unit tests for loading from blob
    
    Part-of: #11293
    ermshiperete committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    d06aa29 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. feat(core): instantiate different processor types in processor_factory

    This moves instantiating the different processor types back to the
    `processor_factory` by adding a new `is_handled` static method on the
    different processors. Also addresses other code review comments.
    
    Also add some more unit tests.
    ermshiperete committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    1c88166 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. feat(core): address code review comments

    - rename `km_core_keyboard_load_from_blob_internal` to
      `keyboard_load_from_blob_internal` since it's not part of the API
    - use size of struct instead of hard-coding minimum KMX file size
    ermshiperete committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    069cd21 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    052ae2e View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Configuration menu
    Copy the full SHA
    11a2a3b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    db64bad View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Configuration menu
    Copy the full SHA
    de863c2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2f3edd3 View commit details
    Browse the repository at this point in the history