-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): implement loading KMX from blob 🎼 #12459
Merged
Merged
Commits on Sep 24, 2024
-
feat(core): implement loading KMX from blob
- split keyboard loading into loading KMX file into blob and then loading the keyboard processor from the blob. - deprecate `km_core_keyboard_load` - move file access next to deprecated method. This is now the only place that loads a file in Core; unit tests have some more places that load files. - introduce GTest and add unit tests for loading from blob Part-of: #11293
Configuration menu - View commit details
-
Copy full SHA for d06aa29 - Browse repository at this point
Copy the full SHA d06aa29View commit details
Commits on Oct 2, 2024
-
feat(core): instantiate different processor types in processor_factory
This moves instantiating the different processor types back to the `processor_factory` by adding a new `is_handled` static method on the different processors. Also addresses other code review comments. Also add some more unit tests.
Configuration menu - View commit details
-
Copy full SHA for 1c88166 - Browse repository at this point
Copy the full SHA 1c88166View commit details
Commits on Oct 7, 2024
-
feat(core): address code review comments
- rename `km_core_keyboard_load_from_blob_internal` to `keyboard_load_from_blob_internal` since it's not part of the API - use size of struct instead of hard-coding minimum KMX file size
Configuration menu - View commit details
-
Copy full SHA for 069cd21 - Browse repository at this point
Copy the full SHA 069cd21View commit details -
Configuration menu - View commit details
-
Copy full SHA for 052ae2e - Browse repository at this point
Copy the full SHA 052ae2eView commit details
Commits on Oct 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 11a2a3b - Browse repository at this point
Copy the full SHA 11a2a3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for db64bad - Browse repository at this point
Copy the full SHA db64badView commit details
Commits on Oct 9, 2024
-
chore(core): Merge remote-tracking branch 'origin/epic/web-core' into…
… feat/core/kbd_from_blob
Configuration menu - View commit details
-
Copy full SHA for de863c2 - Browse repository at this point
Copy the full SHA de863c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f3edd3 - Browse repository at this point
Copy the full SHA 2f3edd3View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.