-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(developer): use richedit in debug memo to support Egyptian cartouches #12464
fix(developer): use richedit in debug memo to support Egyptian cartouches #12464
Conversation
…ches RichEdit allows text selection one character past end-of-string, so we need to cater for that as well in passing text ranges to the character grid. Fixes: #12454
User Test ResultsTest specification and instructions Test Artifacts
|
Adds support for using RichEdit 4.1, and sets the richedit control into the correct mode for rendering arbitrary Unicode correctly. Removes some unnecessary per-character refresh for improved performance. Fixes: #12454
@dinakaranr I think this is happening because you haven't selected a font for the test or 'characters' in the keyboard. If you choose an appropriate font (right-click on the test window to change font), you should find the characters displaying correctly. If you don't have an appropriate font available, you could install the font that is referenced in the corresponding .kps file, and use that. @keymanapp-test-bot retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Changes in this pull request will be available for download in Keyman version 18.0.124-alpha |
RichEdit allows text selection one character past end-of-string, so we need to cater for that as well in passing text ranges to the character grid.
Note: in draft as this uses RichEdit 2.0 which has other spacing issues for complex scripts (e.g. Khmer), need to be basing on RichEdit 4.1 preferably.
Fixes: #12454
User Testing
TEST_KMN_DEBUGGER: In Keyman Developer, open a Keyman .kmn keyboard, and press F5 to start the debugger. Run through a number of normal operations in the debugger, selecting text, typing, etc, and look for any unexpected display issues or anomalies. Pass this test if no issues are encountered.
TEST_LDML_DEBUGGER: In Keyman Developer, open or create a Keyman LDML keyboard, and press F5 to start the debugger. Run through a number of normal operations in the debugger, selecting text, typing, etc, and look for any unexpected display issues or anomalies. Pass this test if no issues are encountered.