Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(common): improve configuration detection for hextobin #12481

Merged
merged 3 commits into from
Oct 7, 2024

Commits on Sep 27, 2024

  1. chore(common): improve configuration detection for hextobin

    This improves #12440. The previous change was a bit fragile if we updated
    commander versions. This change now implements a better solution that
    doesn't rely on dependencies and their locations for detecting if we need
    to run the `configure` action for hextobin.
    ermshiperete committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    968c971 View commit details
    Browse the repository at this point in the history
  2. chore(common): use node to touch file

    The previous attempt failed when building on Windows. Using node should
    work everywhere.
    ermshiperete committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    d552b44 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. chore(common): create flag file without node

    Addresses code review comments.
    ermshiperete committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    3056128 View commit details
    Browse the repository at this point in the history