Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(developer): kmcmplib compiler unit tests 4 #12489

Merged
merged 32 commits into from
Nov 1, 2024
Merged

test(developer): kmcmplib compiler unit tests 4 #12489

merged 32 commits into from
Nov 1, 2024

Conversation

markcsinclair
Copy link
Contributor

Google Test based unit tests for Compiler.cpp

Continues PR #11990

@keymanapp-test-bot skip

@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Sep 30, 2024 •
edited
Loading

User Test Results

Test specification and instructions

User tests are not required

@markcsinclair markcsinclair marked this pull request as draft September 30, 2024 09:30
@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S12 milestone Sep 30, 2024
@markcsinclair markcsinclair self-assigned this Sep 30, 2024
@markcsinclair markcsinclair added test Any acceptance test issue and removed chore labels Sep 30, 2024
@github-actions github-actions bot added the chore label Sep 30, 2024
@markcsinclair markcsinclair changed the title chore(developer): add first three use() test cases in GetXStringImpl_… test(developer): kmcmplib compiler unit tests 4 Sep 30, 2024
@markcsinclair
chore(developer): change initFileGroupArray() to take names; add thre…
8c96f13 
…e use() test cases for non-existent group
@markcsinclair
chore(developer): add three use() test cases for valid group
fc9a97d
@markcsinclair
chore(developer): add GetXStringImpl_type_r test and first test case
947932f
@markcsinclair
chore(developer): add eight test cases for commands without expected …
54b5781 
…delimiters
@markcsinclair
chore(developer): add reset() ERROR_80FeatureOnly test case
b8d2fad
@markcsinclair
chore(developer): Merge branch 'master' into test/developer/kmcmplib-…
6871b35 
…compiler-unit-tests-4
@markcsinclair
chore(developer): add ten use cases for reset() in GetXStringImpl_typ…
eee9cf4 
…e_r test
@markcsinclair
chore(developer): add return() test case to GetXStringImpl_type_r test
ebb6f87
@markcsinclair
chore(developer): add initial three test cases to GetXStringImpl_type…
d269edb 
…_osb test, plus initVKDictionary()
@darcywong00 darcywong00 modified the milestones: A18S12, A18S13 Oct 11, 2024
@markcsinclair
chore(developer): Merge branch 'master' into test/developer/kmcmplib-…
8ba2471 
…compiler-unit-tests-4
@markcsinclair
chore(developer): add ten virtual key test cases (virtual char key)
24377ac
@markcsinclair
chore(developer): add six additional test cases (virtual char key), p…
592ffbd 
…lus three commented-out test cases for issue #12307
@markcsinclair
chore(developer): Merge branch 'master' into test/developer/kmcmplib-…
95e0b20 
…compiler-unit-tests-4
@markcsinclair
chore(developer): correct extern variable initialisation (kmcmp::FMne…
b363568 
…monicLayout)
@markcsinclair
chore(developer): add two test cases for long virtual key names
e54762e
@markcsinclair
chore(developer): three test cases for custom virtual key names
6ec4a47
@markcsinclair
chore(developer): added virtual key names to initVKDictionary()
4b30cc9
@markcsinclair
chore(developer): some clarification of comments on test cases for cu…
c36f093 
…stom name virtual keys
@darcywong00 darcywong00 modified the milestones: A18S13, A18S14 Oct 26, 2024
@markcsinclair
Copy link
Contributor Author

Ready to review.

Some tidying up, with additional initialiser funtions, of gtest-compiler-test.cpp. Most new test cases address use(), reset() and virtual keys. There are some problems with spacing of virtual keys (see #12307), and four commented out test cases partially address these - more will be added when a fix is developed.

@markcsinclair markcsinclair marked this pull request as ready for review October 29, 2024 14:23
mcdurdin
mcdurdin approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markcsinclair markcsinclair merged commit 76e89fb into master Nov 1, 2024
6 checks passed
@markcsinclair markcsinclair deleted the test/developer/kmcmplib-compiler-unit-tests-4 branch November 1, 2024 10:01
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.133-alpha

@markcsinclair markcsinclair mentioned this pull request Nov 4, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdurdin mcdurdin mcdurdin approved these changes

@darcywong00 darcywong00 Awaiting requested review from darcywong00 darcywong00 is a code owner

Assignees

@markcsinclair markcsinclair

Labels
developer/compilers/ developer/ test Any acceptance test issue
Projects
Keyman
Status: Done
Milestone
A18S14
Development

Successfully merging this pull request may close these issues.
4 participants
@markcsinclair @keyman-server @mcdurdin @darcywong00