feat(developer) marker steps 🙀 #9364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srl295
requested review from
mcdurdin,
darcywong00,
jahorton and
rc-swag
as code owners
User Test ResultsTest specification and instructions User tests are not required |
github-actions
bot
added
developer/
common/
developer/compilers/
core/
srl295
commented
Jul 29, 2023
| @@ -27,7 +27,6 @@ Markers can appear in both 'emitting' and 'matching-only' areas: | |||
| #### Match only | |||
|
|
|||
| - `transform from=` to match markers | |||
| - `transform after=` to match markers | |||
There was a problem hiding this comment.
where did this come from?
Base automatically changed from
chore/core/7375-reorder-comments-epic-ldml
to
master
July 29, 2023 22:01
mcdurdin
approved these changes
Jul 31, 2023
Comment on lines
+181
to
+185
| validateVarsMarkers(keyboard: LDMLKeyboard.LKKeyboard, mt : MarkerTracker) : boolean { | ||
| keyboard?.variables?.string?.forEach(({value}) => | ||
| mt.add(MarkerUse.variable, MarkerParser.allReferences(value))); | ||
| return true; | ||
| } |
There was a problem hiding this comment.
This doesn't seem to do validation?
There was a problem hiding this comment.
It supports validation by checking existence. Though I thought maybe there should be a second looser regex that catches invalid marker ids ?
developer/src/kmc-ldml/test/fixtures/sections/vars/fail-markers-badref-0.xml
Outdated
Show resolved
Hide resolved
…s-badref-0.xml Co-authored-by: Marc Durdin <marc@durdin.net>
|
Changes in this pull request will be available for download in Keyman version 17.0.151-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9119
@keymanapp-test-bot skip