chore(linux): Add coverage action to ibus-keyman/build.sh
#9583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ermshiperete
requested review from
darcywong00,
mcdurdin and
jahorton
as code owners
User Test ResultsTest specification and instructions User tests are not required |
ermshiperete
force-pushed
the
chore/linux/coverage
branch
from
7798f73
to
a870b9a
Compare
darcywong00
reviewed
Sep 19, 2023
linux/ibus-keyman/build.sh
Outdated
| @@ -19,11 +19,16 @@ builder_describe \ | |||
| "test" \ | |||
| "install install artifacts" \ | |||
| "uninstall uninstall artifacts" \ | |||
| "report create coverage report" \ | |||
There was a problem hiding this comment.
Rather than making a new action for report, could it be an option --report inside the test action?
(The coverage report depends on test being run, right?)
There was a problem hiding this comment.
Done. Seems a bit weird to call ninja in response to an option, but it works.
This addresses code review comments.
darcywong00
reviewed
Sep 19, 2023
linux/ibus-keyman/build.sh
Outdated
Comment on lines
29
to
31
| builder_describe_internal_dependency \ | ||
| report:engine test:engine | ||
|
|
There was a problem hiding this comment.
Suggested change
| builder_describe_internal_dependency \ | |
| report:engine test:engine |
Now that --coverage is an option checked inside the test action, this can go away, right?
Addresses code review comment.
|
Changes in this pull request will be available for download in Keyman version 17.0.177-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@keymanapp-test-bot skip