fix(web): gesture-engine integration - automated test patchup 🐵 #9719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
Oof. Part of that, at least, is the fact that there are three sets of contact-point (mouse, touch) input-interpreting engines bundled into KMW at this stage - one for the 16.0 OSK, one for the 16.0 banner, and then the new gesture engine. Assuming I have sufficient time during the release cycle, we'll be able to drop the first two in favor of just the new engine, which should bring the filesize growth down a fair bit. Either way, it's going to take a few PRs, at least, to resolve. |
This was referenced Oct 12, 2023
…into fix/web/integration-test-fixes
mcdurdin
approved these changes
Oct 16, 2023
Base automatically changed from
feat/web/key-specific-gesture-integration
to
feature-gestures
October 20, 2023 09:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores all KMW integration tests to working order for the feature-gestures feature branch. It was temporarily broken during early integration of the new gesture-engine into the existing OSK.
Also includes #9718's changes.
Also adds some robustness to the gesture-engine, should an ongoing gesture be interrupted. Be it by debugger or some other system modal interaction, the engine will examine the list of "current touches" for the next touch received and cancel all
GestureSources that no longer have existing entries in the event'sTouchLists, allowing the engine to reset and recover.Finally, this PR helps resolve a few cases within the gesture engine that wasn't fully clearing out no-longer-useful entries in certain state-tracking arrays. Memory leaks, or similar, = bad.
I thought about keeping this included with #9690, but the two change sets are pretty orthogonal - so it'd be best to review separately. I also tried to rebase this onto #9657... but there were some other changes necessary from #9690, and I'm not sure what those are. I don't think it worth the trouble of chasing something ambiguous like that down just to do a one-PR-earlier rebase.
@keymanapp-test-bot skip