Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): initial normalization 🙀 #9728

Merged
merged 23 commits into from
Oct 20, 2023
Merged

feat(core): initial normalization 🙀 #9728

merged 23 commits into from
Oct 20, 2023

Commits on Oct 9, 2023

  1. chore(core): Some failing normalization transform tests 🙀 

    For: #9468
    @srl295
    srl295 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    dcb6796 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Merge branch 'master' into feat/core/9468-normalization-epic-ldml

    @srl295
    srl295 authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    8c4642a View commit details
    Browse the repository at this point in the history

  2. chore(core): dx: improve test output 🙀 

    - colorize ldml test

For: #9468
    @srl295
    srl295 committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    15e6fb6 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. feat(core): ldml normalization 🙀 

    - 0 steps forward, 4294967294 steps back

For: #9468
    @srl295
    srl295 committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    daa0523 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. feat(core): ldml normalization 🙀 

    - change tests to NFD for now

For: #9468
    @srl295
    srl295 committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    522d2ef View commit details
    Browse the repository at this point in the history

  2. feat(core): ldml normalization 🙀 

    - split out 'process_key_string'

For: #9468
    @srl295
    srl295 committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    e64f596 View commit details
    Browse the repository at this point in the history

  3. feat(core): ldml normalization 🙀 

    - change more tests to NFD for now

For: #9468
    @srl295
    srl295 committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    736af4b View commit details
    Browse the repository at this point in the history

  4. feat(core): ldml normalization 🙀 

    - more progress in the normalization pipeline. Trying to keep it from leaking.
- normalize output to NFC.
- normalize json test data to NFC (both context and expected).
- we do NOT try to normalize the 'embedded' strings currently.
- yet more test data fixes (turns out u+00e0 ≠ u+00e8)

For: #9468
    @srl295
    srl295 committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    a577bd2 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into feat/core/9468-normalization-epic-ldml

    @srl295
    srl295 authored Oct 12, 2023
    Configuration menu
    Copy the full SHA
    84b4836 View commit details
    Browse the repository at this point in the history

  6. feat(core): ldml normalization 🙀 

    - fix windows build

For: #9468
    @srl295
    srl295 committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    b3de1ff View commit details
    Browse the repository at this point in the history

  7. feat(core): ldml normalization 🙀 

    - fix unnecessary test churn.

For: #9468
    @srl295
    srl295 committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    95ad1c4 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. feat(core): ldml normalization 🙀 

    - fix int -> auto

For: #9468
    @srl295
    srl295 committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    bf15feb View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Merge branch 'master' into feat/core/9468-normalization-epic-ldml

    @srl295
    srl295 authored Oct 16, 2023
    Configuration menu
    Copy the full SHA
    79f37f7 View commit details
    Browse the repository at this point in the history

  2. fix(core): ldml update to normalization per review 🙀 

    - simplify normalize_nfc and normalize_nfd functions

For: #9468
    @srl295
    srl295 committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    9ee183c View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. fix(core): ldml update to normalization per review 🙀 

    For: #9468

Co-authored-by: Marc Durdin <marc@durdin.net>
    @srl295 @mcdurdin
    srl295 and mcdurdin committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    93e1c18 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. fix(core): ldml more updates to normalization per review 🙀 

    - verify marker string as it's popped off
- add a missing pragma to debuglog.h
- move UErrorCode out of ldml_processor, change normalization functions to return true on success

For: #9468
    @srl295
    srl295 committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    9dbf70c View commit details
    Browse the repository at this point in the history

  2. fix(core): ldml more updates to normalization per review 🙀 

    - refactor internal normalization call

For: #9468
    @srl295
    srl295 committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    f1b12a1 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into feat/core/9468-normalization-epic-ldml

    @srl295
    srl295 authored Oct 18, 2023
    Configuration menu
    Copy the full SHA
    c4c7361 View commit details
    Browse the repository at this point in the history

  4. fix(core): ldml more updates to normalization per review 🙀 

    - consistency

For: #9468
    @srl295
    srl295 committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    3723e6b View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. fix(core): ldml more updates to normalization per review 🙀 

    - move meat of uassert_success() into an inline

For: #9468
    @srl295
    srl295 committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    4afe038 View commit details
    Browse the repository at this point in the history

  2. fix(core): ldml more updates to normalization per review 🙀 

    - improve assert failure handling- fix a potential heap leak

For: #9468
    @srl295
    srl295 committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    1d9820b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into feat/core/9468-normalization-epic-ldml

    @srl295
    srl295 authored Oct 19, 2023
    Configuration menu
    Copy the full SHA
    9292410 View commit details
    Browse the repository at this point in the history

  4. fix(core): ldml more updates to normalization per review 🙀 

    - reduce function depth
- catch another gotcha (valid was being overwritten)

For: #9468
    @srl295
    srl295 committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    4cdc2c3 View commit details
    Browse the repository at this point in the history