Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up a few minor discrepancies in builder.inc.sh #9731

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Oct 10, 2023

- Some uses of `KEYMAN_ROOT` (not cross-repo compatible)
- `set -eu` and `SHLVL` now set there as well
@keymanapp-test-bot keymanapp-test-bot bot added this to the A17S23 milestone Oct 10, 2023
@ermshiperete
Copy link
Contributor

I guess we don't use the shared site scripts in the keyman repo yet, that's why we have a builder.inc.sh in both places?

@mcdurdin
Copy link
Member Author

I guess we don't use the shared site scripts in the keyman repo yet, that's why we have a builder.inc.sh in both places?

Good idea -- I hadn't really considered sharing back to the keyman repo. Sharing the script back to the keyman repo could be considered in the future, although most of the files in _common are really only site-relevant at present (so we may want to consider this carefully). But for now, just sharing the web site infrastructure is a good step forward.

@mcdurdin mcdurdin merged commit e511e39 into master Oct 11, 2023
25 checks passed
@mcdurdin mcdurdin deleted the chore/builder-inc-sh-cleanup branch October 11, 2023 02:09
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.187-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants