refactor(web): drops WET button-class Web enum 🐵 #9769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required |
keymanapp-test-bot
bot
changed the title
mcdurdin
approved these changes
Oct 16, 2023
common/web/types/src/keyman-touch-layout/keyman-touch-layout-file.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Marc Durdin <marc@durdin.net>
…actor/web/common-key-style-class-enum
Base automatically changed from
refactor/web/common-layout-typing
to
feature-gestures
October 20, 2023 09:12
…key-style-class-enum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows KMW to directly use the
common/web/typeskey-styling class enumTouchLayoutKeySp, rather than maintaining its own variant. This does mean adding a couple of new values to said enum, as well as forcing it to aconst enumthat can compile out. Both sets of changes are necessary if we are to have KMW directly reference values fromTouchLayoutKeySpat this time.Motivated by #9664 (comment).
No biggie if we decide to abort this for now.
@keymanapp-test-bot skip