Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(windows): merge master epic win upg cert 📲 #9770

Merged
merged 9 commits into from
Oct 19, 2023

Conversation

rc-swag
Copy link
Contributor

@rc-swag rc-swag commented Oct 16, 2023

The proxy dll projects were incorrectly setup and did not import the version information. The verify_certificate update exposed this problem.

@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Oct 16, 2023
@keymanapp-test-bot keymanapp-test-bot bot added this to the A17S24 milestone Oct 16, 2023
@rc-swag rc-swag changed the title Chore/merge master epic win upg cert chore(windows): merge master epic win upg cert Oct 16, 2023
@rc-swag rc-swag changed the base branch from master to epic/windows-upgrades October 16, 2023 05:04
@keymanapp-test-bot keymanapp-test-bot bot changed the title chore(windows): merge master epic win upg cert chore(windows): merge master epic win upg cert 📲 Oct 16, 2023
@rc-swag rc-swag marked this pull request as ready for review October 16, 2023 05:05
@rc-swag rc-swag marked this pull request as draft October 16, 2023 06:11
@rc-swag
Copy link
Contributor Author

rc-swag commented Oct 17, 2023

This is the commit f53421b that fixes the failing Windows build.

@keymanapp-test-bot skip

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-missing User tests have not yet been defined for the PR label Oct 17, 2023
@rc-swag rc-swag marked this pull request as ready for review October 17, 2023 07:30
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rc-swag rc-swag merged commit 46948cc into epic/windows-upgrades Oct 19, 2023
9 checks passed
@rc-swag rc-swag deleted the chore/merge-master-epic-win-upg-cert branch October 19, 2023 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants