Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(linux): Rename (lib)kmnkbp to (lib)keymancore 〽️ #9793

Merged
merged 5 commits into from
Oct 24, 2023

Conversation

ermshiperete
Copy link
Contributor

@ermshiperete ermshiperete commented Oct 18, 2023

Part of #9733.

@keymanapp-test-bot skip

@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Oct 18, 2023

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@ermshiperete ermshiperete force-pushed the chore/linux/9733_RenameLibknmkbp branch from 653b5e7 to 52bb859 Compare October 19, 2023 08:35
@ermshiperete ermshiperete marked this pull request as ready for review October 19, 2023 14:29
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but now I am wondering why we have both keyman-engine.vcxproj which appears to link keymancore.lib and keyman32.vcxproj which has links libkeymancore.a? (@rc-swag?)

core/src/version.rc Outdated Show resolved Hide resolved
@@ -1,43 +1,43 @@
libkmnkbp0.so.0 libkmnkbp0-0 #MINVER#
libkeymancore.so.1 libkmnkbp0-0 #MINVER#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still supposed to be libkmnkbp0-0 here? And noting the filename is still given as libkmnkbp0-0.symbols.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, libkmnkbp0-0 is the Debian package name which is renamed in #9795

Co-authored-by: Marc Durdin <marc@durdin.net>
Base automatically changed from chore/linux/9733_RenameDefines to master October 20, 2023 10:29
@ermshiperete ermshiperete merged commit 38f3535 into master Oct 24, 2023
16 of 17 checks passed
@ermshiperete ermshiperete deleted the chore/linux/9733_RenameLibknmkbp branch October 24, 2023 09:08
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.197-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants