-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(linux): Rename (lib)kmnkbp to (lib)keymancore 〽️ #9793
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
653b5e7
to
52bb859
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but now I am wondering why we have both keyman-engine.vcxproj which appears to link keymancore.lib and keyman32.vcxproj which has links libkeymancore.a? (@rc-swag?)
@@ -1,43 +1,43 @@ | |||
libkmnkbp0.so.0 libkmnkbp0-0 #MINVER# | |||
libkeymancore.so.1 libkmnkbp0-0 #MINVER# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still supposed to be libkmnkbp0-0 here? And noting the filename is still given as libkmnkbp0-0.symbols.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, libkmnkbp0-0
is the Debian package name which is renamed in #9795
Co-authored-by: Marc Durdin <marc@durdin.net>
…/linux/9733_RenameLibknmkbp
…/linux/9733_RenameLibknmkbp
Changes in this pull request will be available for download in Keyman version 17.0.197-alpha |
Part of #9733.
@keymanapp-test-bot skip