Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(linux): Rename libkmnkbp0-0 package 〽️ #9795

Merged
merged 1 commit into from
Oct 24, 2023
Merged

chore(linux): Rename libkmnkbp0-0 package 〽️ #9795

merged 1 commit into from
Oct 24, 2023

Conversation

ermshiperete
Copy link
Contributor

@ermshiperete ermshiperete commented Oct 18, 2023 •
edited
Loading

Closes #9733.

User Testing

TEST_SMOKE: Run a quick smoke test: install the packages from this PR, then test that installing a keyboard and typing with the keyboard still works.

@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Oct 18, 2023
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Oct 18, 2023 •
edited
Loading

User Test Results

Test specification and instructions

  • ✅ TEST_SMOKE (PASSED): Tested with the attached PR build (keyman 17.0.196-alpha-local (package version 17.0.196-1~PR-9795-1597.1+mantic1) in Ubuntu 23.10 Mantic Minotaur OS (VM) and here is my observation: 1. Downloaded and installed some keyboards (like Amharic, Khmer, Korean Korda, Sanskrit etc., ) using keyman configuration dialog. 2. Tested the keyboards on LibreOffice Writer, Mozilla browser (search bar), and Text Editor and I could use the keyboards without any problem. 3. Also, I did the smoke test on Wasta 20.04 Linux OS and it seems to be working fine. (notes)

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the A17S24 milestone Oct 18, 2023
@ermshiperete ermshiperete marked this pull request as draft October 18, 2023 17:16
@ermshiperete ermshiperete force-pushed the chore/linux/9733_RenameKeyboardprocessor branch from 5083461 to eac4802 Compare October 19, 2023 14:30
@ermshiperete
Copy link
Contributor Author

Debian packaging GHA check fails because the GHA on master is used for the build and that still contains the old name.

@mcdurdin
Copy link
Member

Debian packaging GHA check fails because the GHA on master is used for the build and that still contains the old name.

Tricky for this kind of thing... is there a good way around it?

@ermshiperete ermshiperete mentioned this pull request Oct 20, 2023
Merged
@ermshiperete
Copy link
Contributor Author

Debian packaging GHA check fails because the GHA on master is used for the build and that still contains the old name.

Tricky for this kind of thing... is there a good way around it?

#9812 😄

@ermshiperete ermshiperete force-pushed the chore/linux/9733_RenameKeyboardprocessor branch from d979c04 to dac89f0 Compare October 20, 2023 14:11
@ermshiperete ermshiperete force-pushed the chore/linux/9733_RenamePackage branch 2 times, most recently from d3bb740 to 1abd89f Compare October 20, 2023 14:16
@ermshiperete ermshiperete force-pushed the chore/linux/9733_RenameKeyboardprocessor branch from dac89f0 to f4d8529 Compare October 20, 2023 15:30
@ermshiperete
chore(linux): Rename libkmnkbp0-0 package
2e5e586 
Also removes the temporary libkeymancore/libkmnkbp hack that we put in
for packaging GHA.

Closes #9733.
@ermshiperete ermshiperete marked this pull request as ready for review October 23, 2023 08:41
mcdurdin
mcdurdin approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bharanidharanj
Copy link

Test Results

  • TEST_SMOKE (PASSED): Tested with the attached PR build (keyman 17.0.196-alpha-local (package version 17.0.196-1~PR-9795-1597.1+mantic1) in Ubuntu 23.10 Mantic Minotaur OS (VM) and here is my observation: 1. Downloaded and installed some keyboards (like Amharic, Khmer, Korean Korda, Sanskrit etc., ) using keyman configuration dialog. 2. Tested the keyboards on LibreOffice Writer, Mozilla browser (search bar), and Text Editor and I could use the keyboards without any problem. 3. Also, I did the smoke test on Wasta 20.04 Linux OS and it seems to be working fine.

..smoke test on Ubuntu 23.10 mantic OS

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Oct 24, 2023
Base automatically changed from chore/linux/9733_RenameKeyboardprocessor to master October 24, 2023 09:09
@ermshiperete ermshiperete merged commit 42f826d into master Oct 24, 2023
17 checks passed
@ermshiperete ermshiperete deleted the chore/linux/9733_RenamePackage branch October 24, 2023 09:09
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.197-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdurdin mcdurdin mcdurdin approved these changes

@darcywong00 darcywong00 Awaiting requested review from darcywong00 darcywong00 is a code owner

@rc-swag rc-swag Awaiting requested review from rc-swag rc-swag is a code owner

Assignees
No one assigned
Labels
chore core/ Keyman Core has-user-test linux/
Projects
None yet
Milestone
A17S24
Development

Successfully merging this pull request may close these issues.

chore(linux): Rename libkmnkbp to libkeymancore
4 participants
@ermshiperete @mcdurdin @bharanidharanj @keyman-server