-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mac): move keyboard menu items to main Input Menu from submenu 🔥 🍒 🏠 #9810
Merged
mcdurdin
merged 3 commits into
stable-16.0
from
fix/mac/cherry-pick/sonoma-keyboards-menu
Oct 20, 2023
Merged
fix(mac): move keyboard menu items to main Input Menu from submenu 🔥 🍒 🏠 #9810
mcdurdin
merged 3 commits into
stable-16.0
from
fix/mac/cherry-pick/sonoma-keyboards-menu
Oct 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Input Menu and eliminated Keyboards submenu
Co-authored-by: Marc Durdin <marc@durdin.net>
keymanapp-test-bot
bot
added
has-user-test
user-test-required
User tests have not been completed
labels
Oct 20, 2023
User Test ResultsTest specification and instructions
Test Artifacts
|
keymanapp-test-bot
bot
changed the title
fix(mac): move keyboard menu items to main Input Menu from submenu 🔥 🍒
fix(mac): move keyboard menu items to main Input Menu from submenu 🔥 🍒 🏠
Oct 20, 2023
github-actions
bot
added
mac/
cherry-pick
Change already merged into another (stable) branch
fix
labels
Oct 20, 2023
rc-swag
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on the basis of #9777 RSLGTM
keymanapp-test-bot
bot
removed
the
user-test-required
User tests have not been completed
label
Oct 20, 2023
Changes in this pull request will be available for download in Keyman version 16.0.142 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #9777 to stable-16.0
Previously, Keyman for Mac supported switching of keyboards using a submenu from the Keyman section of the Input Menu:
This change eliminates the submenu and lists the keyboards at the top of the Keyman section of the Input menu:
It is helpful to make this change now because the Keyboards submenu is not functioning properly with macOS Sonoma, 14.0 (see #9684).
Fixes #9684
User Testing
TEST_KEYBOARD_SELECTION:
Run Keyman for Mac and verify that a single keyboard is selected in the Keyman section of the Input Menu. Also, confirm that the selected keyboard is actually the one that is processing keystrokes when typing in a text document.
TEST_CHANGING_KEYBOARDS:
Select a different keyboard from the list in the Keyman section of the Input Menu and verify that:
TEST_CONFIGURATION_MENU:
Select the 'Configuration...' menu item and confirm that it brings up the Configuration window.
TEST_SHOW_OSK_MENU:
Select the 'On-Screen Keyboard' menu item and confirm that it brings up the On-screen Keyboard window.
TEST_ABOUT_MENU:
Select the 'About' menu item and confirm that it brings up the About dialog.
TEST_ADD_KEYBOARD:
Go to the Configuration window and either install a new keyboard or enable one that is already installed by clicking on the checkbox in the leftmost column of the Keyboards pane. Confirm that the newly added keyboard is now listed in the Keyman section of the Input Menu.
TEST_REMOVE_SELECTED_KEYBOARD:
Go to the Configuration window and disable the keyboard that is currently active in Keyman by unchecking the corresponding checkbox in the leftmost column of the Keyboards pane. Confirm that:
Go to the Configuration window and disable all the keyboards that are currently active in Keyman by unchecking the checkboxes in the leftmost column of the Keyboards pane. Go look at the Input Menu and confirm that the only keyboard listed is a placeholder that says: '(No Keyboard Configured)':
When the Input Menu is opened, confirm that the contents of the menu are fully populated and you do not need to open and close the Input Menu a few times for the Keyman section of the menu to appear.