Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: race condition when multiple events received for single PR #416

Open
mcdurdin opened this issue Jan 12, 2024 · 0 comments
Open

bug: race condition when multiple events received for single PR #416

mcdurdin opened this issue Jan 12, 2024 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@mcdurdin
Copy link
Member

It is possible for the test bot to generate multiple User Test Result comments if multiple events are received when a PR/issue is created, before the first User Test Result comment is created.

image

There is a known race condition here -- you see the user test results showing up twice -- because of the async nature of the bot, it can end up creating two user test result comments when multiple events are received. Workaround is to delete one of them -- doesn't matter which one.

The proper fix is to serialize the responses from the test bot better, which we could do queuing actions, and signaling completion of each test bot action before starting the next one.

Or at least serialize actions for a given PR/issue. But that's a little more plumbing to get right.

@mcdurdin mcdurdin added the bug Something isn't working label Jan 12, 2024
@mcdurdin mcdurdin added this to the Future milestone Jan 12, 2024
@rc-swag rc-swag self-assigned this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants