-
Notifications
You must be signed in to change notification settings - Fork 1
draft spec for join-addField #9
base: main
Are you sure you want to change the base?
Conversation
Please remove all .idea files and other temporary files like node_modules, etc. |
I now remove .idea files, node_modules and added .gitignore |
spec/spec_join_addfields/dev.html
Outdated
status: "Unofficial Draft", | ||
publisher: "IDLab - Ghent University - imec", | ||
authors: [ | ||
"Ben De Meester", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elsdvlee don't forget to update the authors :)
|
||
The Range of a <dfn>parent logical source</dfn> property is a [Logical Source](https://kg-construct.github.io/rml-io/spec/docs/#defining-logical-sources) and describes the data source that supplies the additional data and is the right side of the join. | ||
|
||
### Join Conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: clarify that this is in fact exactly the same construct/definition as in RML-Core? Or are there differences?
Els: can we also optionally declare a join function here, to allow not only equijoins (default) but also other joins | ||
</aside> | ||
|
||
### Add Field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO clarify that the reference expression of the parent logical source must then be used, and overwrites any conflicting reference expressions of the child logical source? (so you can then refer to the Alias)
|
||
### Add Field Alias | ||
|
||
If the reference expression of the field of the parent logical source has a duplicated value in the child logical source, the **add field alias** property (`rml:addFieldAlias`) MUST be used instead of the **add field** property. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this is different from my suggestion: overwrite by default. Up for discussion, whether we want the engine to throw an error asap vs be more lenient
No description provided.