Skip to content
This repository has been archived by the owner on Feb 15, 2024. It is now read-only.

draft spec for join-addField #9

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Conversation

elsdvlee
Copy link
Collaborator

No description provided.

@dachafra
Copy link
Member

dachafra commented Nov 15, 2023

Please remove all .idea files and other temporary files like node_modules, etc.

@elsdvlee
Copy link
Collaborator Author

I now remove .idea files, node_modules and added .gitignore

status: "Unofficial Draft",
publisher: "IDLab - Ghent University - imec",
authors: [
"Ben De Meester",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elsdvlee don't forget to update the authors :)


The Range of a <dfn>parent logical source</dfn> property is a [Logical Source](https://kg-construct.github.io/rml-io/spec/docs/#defining-logical-sources) and describes the data source that supplies the additional data and is the right side of the join.

### Join Conditions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: clarify that this is in fact exactly the same construct/definition as in RML-Core? Or are there differences?

Els: can we also optionally declare a join function here, to allow not only equijoins (default) but also other joins
</aside>

### Add Field
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO clarify that the reference expression of the parent logical source must then be used, and overwrites any conflicting reference expressions of the child logical source? (so you can then refer to the Alias)


### Add Field Alias

If the reference expression of the field of the parent logical source has a duplicated value in the child logical source, the **add field alias** property (`rml:addFieldAlias`) MUST be used instead of the **add field** property.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this is different from my suggestion: overwrite by default. Up for discussion, whether we want the engine to throw an error asap vs be more lenient

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants