-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 현재 모집중인 모집공고 목록 조회 기능 구현 완료 #658
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
새로운 랜딩 페이지에서는 기존에 사용되던 '모집 공고 목록(최근 5건)' API를 대체하여 모집 중인 공고만 보여주는 방식으로 변경되는 건가요? 만약 그렇다면, 기존 API에 @deprecated 어노테이션을 추가해 사용 중단을 명시적으로 알리고, 추후 제거하는 것이 좋을 것 같아요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (1)
- src/main/java/page/clab/api/global/config/SecurityConstants.java: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/main/java/page/clab/api/domain/hiring/recruitment/application/dto/response/RecruitmentOpenResponseDto.java:11
- The id field should be of type Long instead of long to handle potential null values.
private Long id;
기존에 사용되던 API는 그대로 사용하고, 새롭게 구현된 API는 모집 폼에서 현재 모집 중인 공고만 선택할 수 있도록 하려고 합니다. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
작업된 API에 대해 충분히 이해했습니다. 고생 많으셨어요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인했습니다!👍👍
Summary
현재 모집 중인(
RecruitmentStatus.OPEN
) 모집 공고들을 조회할 수 있는 기능을 구현했습니다.Tasks
Screenshot