Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove non-determinism #51

Open
bytewife opened this issue Sep 3, 2022 · 0 comments
Open

Remove non-determinism #51

bytewife opened this issue Sep 3, 2022 · 0 comments
Labels
bug Something isn't working feedback requested help wanted Extra attention is needed

Comments

@bytewife
Copy link
Member

bytewife commented Sep 3, 2022 •
edited
Loading

I believe this is caused by a desync between the React's asynchronous state management and the synchronous game logic. I'm unsure if there's a good way to handle this without a massive refactor (replacing React entirely with some other data-synchronous framework)
This was referenced Sep 3, 2022
Merged
Merged
bytewife added a commit that referenced this issue Sep 9, 2022
@bytewife
Add falling block animation with <FallingBlock/> (#52)
1229504 
- This issue adds a falling animation to board blocks that float above
the ground, and to the player block when it the 'instant drop` action is
performed.
Note: Although slight non-deterministic behavior existed before this PR,
it is more apparent now during the fall animations. This should be
addressed in #51
@bytewife bytewife changed the title Change <GameLoop/>'s useStates to useReducer Remove non-determinism Oct 11, 2022
@bytewife bytewife added bug Something isn't working help wanted Extra attention is needed feedback requested labels Oct 11, 2022
@bytewife bytewife mentioned this issue Oct 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working feedback requested help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bytewife