Fix various non-determinism bugs using useReducer and other guards
#53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkysen
reviewed
Sep 7, 2022
src/components/FallingBlock.tsx
Outdated
| @@ -9,7 +9,7 @@ export const FallingBlock = React.memo( ({ fallingLetters, durationRate }: {fall | |||
| <FallingLetter | |||
| fallingLetterBeforeAndAfter={fallingLetterBeforeAndAfter} | |||
| durationRate={durationRate} | |||
| key={`f${fallingLetterBeforeAndAfter[0].r}${fallingLetterBeforeAndAfter[0].c}`} | |||
| key={`${Math.random()}${fallingLetterBeforeAndAfter[0].r}${fallingLetterBeforeAndAfter[0].c}`} | |||
kkysen
requested changes
Sep 7, 2022
src/GameLoop.tsx
Outdated
| fallingLettersBeforeAndAfter: [], | ||
| }; | ||
|
|
||
| const reducer = (state, action) => { |
src/GameLoop.tsx
Outdated
| @@ -103,6 +103,39 @@ const timestamps = { | |||
| playerInstantDropAnimDurationMilliseconds: 0, | |||
| }; | |||
|
|
|||
| const playerCellsInit = generateUserCells(); | |||
| const initialState = { | |||
src/GameLoop.tsx
Outdated
| fallingLettersBeforeAndAfter: [], | ||
| }; | ||
|
|
||
| const reducer = (state, action) => { |
There was a problem hiding this comment.
Please type this. You probably won't need a default case if you type it correctly (as a discriminated union).
There was a problem hiding this comment.
Done. Do you have any suggested improvements for brevity?
src/GameLoop.tsx
Outdated
| const playerCellsInit = generateUserCells(); | ||
| const initialState = { | ||
| boardCellMatrix: createBoard(BOARD_ROWS, BOARD_COLS), | ||
| playerPos:[...spawnPos] as const, |
There was a problem hiding this comment.
Will format code afterwards
bytewife
force-pushed
the
useReducer_refactor
branch
from
6933616
to
5925702
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are bugs regarding floating blocks lingering when falling, floating cells not falling, and cells not updating their
hasMatchedvariable. I believe this is due to React's async state updates, causing game logic conditionals to perform at incorrectly. Various guards have been added to ensure these things do not affect gameplay.