Skip to content

Commit

Permalink
* Replaced systemProperties with systemPropertyVariables
Browse files Browse the repository at this point in the history
  * preventing deprecated warnings with surefire/failsafe plugin.
* Fixed some grammar/typos
  • Loading branch information
khmarbaise committed Aug 12, 2023
1 parent 5f31539 commit 4f9b950
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 16 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -146,10 +146,10 @@ will execute the integration tests which checks the functionality; The second pa
<!--
! currently needed to run integration tests.
-->
<systemProperties>
<systemPropertyVariables>
<maven.version>${maven.version}</maven.version>
<maven.home>${maven.home}</maven.home>
</systemProperties>
</systemPropertyVariables>
</configuration>
<executions>
<execution>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,14 +101,14 @@ and a part which is pom like
* It's bound to versions of Maven core which might caused issues during testing with other versions
of Maven.
* https://maven.apache.org/plugin-testing/maven-plugin-testing-harness/getting-started/index.html
* Also JUnit 4 based.
* Also, JUnit 4 based.

//TODO: RECONSIDER this content...

=== Mock Repository Manager

Currently it's only possible to have a single instance of the mock repository manager running which
is based on the limited concept cause we need to define it in the `pom.xml`. Of course
Currently, it's only possible to have a single instance of the mock repository manager running which
is based on the limited concept because we need to define it in the `pom.xml`. Of course,
we could start two or more instances but this would make the setup more or less unreadable.

=== Why not Spock?
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ did on plain command line and take a look into it. The output of the build has b
//FIXME: Needs to be implemented

=== Several Test Cases
If we like to define several integration test cases within a single test class `SeveralMavenIT`
If we like to define some integration test cases within a single test class `SeveralMavenIT`
we have to define different methods, which are the test cases. This results in the following
class layout:
[source,java]
Expand Down Expand Up @@ -397,7 +397,7 @@ directory will look like this:
Based on the structure you can exactly dive into each test case separately and take
a look at the console output of the test case via `mvn-stdout.log` or maybe in case of errors
in the `mvn-stderr.log`. In the `project` directory you will find the usual `target` directory,
which contains the Maven output which might be interesting as well. Furthermore the
which contains the Maven output which might be interesting as well. Furthermore, the
local cache (aka maven repository) is available separately for each test case and can be found
in the `.m2/repository` directory.

Expand Down Expand Up @@ -1537,7 +1537,7 @@ The `stderr` output can be accessed as well like this:

include::{itfexample}/itf-examples/src/test/java/com/soebes/itf/examples/LogoutputIT.java[tag=error]

A full fledged example can be found `itf-examples/src/test/java/com/soebes/itf/examples/LogoutputIT.java`
A full-fledged example can be found `itf-examples/src/test/java/com/soebes/itf/examples/LogoutputIT.java`
within the itf project.

=== Expressing Assertions
Expand Down Expand Up @@ -1614,7 +1614,7 @@ The next step is to {intellij-remote}[configure remote debugging] which means to
as port and check if you are using JDK8 or JDK9+ in your configuration.

I recommend to start only a single integration test case via the above described run configuration,
in debugging mode otherwise all processes woulduse the same port which would result in failure
in debugging mode otherwise all processes would use the same port which would result in failure
because only one can use that port.

==== Eclipse
Expand Down
4 changes: 2 additions & 2 deletions itf-examples/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,10 @@
<!--
! currently needed to run integration tests.
-->
<systemProperties>
<systemPropertyVariables>
<maven.version>${maven.version}</maven.version>
<maven.home>${maven.home}</maven.home>
</systemProperties>
</systemPropertyVariables>
<properties>
<configurationParameters>
junit.jupiter.execution.parallel.enabled=true
Expand Down
4 changes: 2 additions & 2 deletions itf-failure-plugin/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -161,10 +161,10 @@
<configuration>
<forkCount>5</forkCount>
<reuseForks>true</reuseForks>
<systemProperties>
<systemPropertyVariables>
<maven.version>${maven.version}</maven.version>
<maven.home>${maven.home}</maven.home>
</systemProperties>
</systemPropertyVariables>
<properties>
<configurationParameters>
junit.jupiter.execution.parallel.enabled = false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@ under the License.
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-failsafe-plugin</artifactId>
<version>3.0.0-M5</version>
<version>3.1.2</version>
<configuration>
<systemProperties>
<systemPropertyVariables>
<maven.version>${maven.version}</maven.version>
<maven.home>${maven.home}</maven.home>
</systemProperties>
</systemPropertyVariables>
</configuration>
<executions>
<execution>
Expand Down

0 comments on commit 4f9b950

Please sign in to comment.