Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency org.springframework.boot:spring-boot-starter-parent to v3 #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update dependency org.springframework.boot:spring-boot-starter-parent to v3 #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<parent>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-parent</artifactId>
<version>2.5.5</version>
<version>3.3.5</version>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Based on the analysis of the codebase, I can now provide a final response:

Spring Boot 3.3.5 version needs critical compatibility updates

The Spring Boot upgrade to version 3.3.5 requires several important changes:

  • Java version needs to be updated from 1.8 to at least 17 (required by Spring Boot 3.x)
  • The maven-surefire-plugin version 3.0.0-M3 is outdated and should be updated to at least 3.1.2 for Spring Boot 3.x
  • The codebase uses JUnit Jupiter annotations which are compatible, but the test configuration might need updates for Spring Boot 3.x WebTestClient

Note: I'm not addressing the specific version number (3.3.5) concern from the original review comment as we couldn't verify if a newer 3.3.x version exists in the sandbox environment. Instead, I'm focusing on the verified compatibility issues found in the codebase that need to be addressed for this major version upgrade.

🔗 Analysis chain

Consider using the latest 3.3.x version

The PR updates to version 3.3.5, but Spring Boot 3.3.6 is available with additional bug fixes and security patches.

Since we couldn't verify the latest Spring Boot version through Maven in the sandbox environment, let me try a different approach to analyze the codebase for Spring Boot version-related configurations.

Let me check the application configuration and main application class to understand the Spring Boot setup better.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify if a newer version is available in the 3.3.x line
# Use Maven to check for updates in the org.springframework.boot:spring-boot-starter-parent artifact

mvn versions:display-dependency-updates | grep "spring-boot-starter-parent"

Length of output: 200

Script:

#!/bin/bash
# Check for Spring Boot version and related configurations in pom.xml
cat pom.xml

Length of output: 1575

Script:

#!/bin/bash
# Look for Spring Boot specific annotations and configurations
rg -l "org.springframework.boot"

Length of output: 149

Script:

#!/bin/bash
# Search for Spring configuration files
fd -e yml -e properties -e xml

Length of output: 82

Script:

#!/bin/bash
# Check application.properties content
cat src/main/resources/application.properties

Length of output: 47

Script:

#!/bin/bash
# Check main application class
cat src/main/java/com/example/demo/DemoApplication.java

Length of output: 473

Script:

#!/bin/bash
# Check test class for Spring Boot test configurations
cat src/test/java/com/example/demo/DemoApplicationTests.java

Length of output: 773

<relativePath/> <!-- lookup parent from repository -->
</parent>

Expand Down